chore: merge web-components-v3 feature branch #31288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
a team,
spmonahan,
micahgodbolt,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
fabricteam
reviewed
May 6, 2024
|
/azp run |
📊 Bundle size report✅ No changes found |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 36 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 613 | 647 | 5000 | |
| Button | mount | 308 | 296 | 5000 | |
| Field | mount | 1139 | 1143 | 5000 | |
| FluentProvider | mount | 704 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 70 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 36 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 81 | 10 | |
| MakeStyles | mount | 850 | 867 | 50000 | |
| Persona | mount | 1744 | 1740 | 5000 | |
| SpinButton | mount | 1390 | 1449 | 5000 | |
| SwatchPicker | mount | 1495 | 1556 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 93 | 72 | 1.29:1 |
| PortalMinimalPerf.default | 99 | 80 | 1.24:1 |
| SkeletonMinimalPerf.default | 220 | 199 | 1.11:1 |
| SegmentMinimalPerf.default | 206 | 189 | 1.09:1 |
| ChatDuplicateMessagesPerf.default | 172 | 160 | 1.08:1 |
| RefMinimalPerf.default | 114 | 106 | 1.08:1 |
| ButtonMinimalPerf.default | 95 | 89 | 1.07:1 |
| ButtonSlotsPerf.default | 339 | 316 | 1.07:1 |
| LabelMinimalPerf.default | 228 | 213 | 1.07:1 |
| LayoutMinimalPerf.default | 205 | 191 | 1.07:1 |
| ProviderMinimalPerf.default | 208 | 194 | 1.07:1 |
| CarouselMinimalPerf.default | 270 | 254 | 1.06:1 |
| ImageMinimalPerf.default | 231 | 218 | 1.06:1 |
| StatusMinimalPerf.default | 414 | 391 | 1.06:1 |
| IconMinimalPerf.default | 388 | 365 | 1.06:1 |
| TreeWith60ListItems.default | 94 | 89 | 1.06:1 |
| ChatMinimalPerf.default | 464 | 441 | 1.05:1 |
| ChatWithPopoverPerf.default | 205 | 196 | 1.05:1 |
| GridMinimalPerf.default | 196 | 187 | 1.05:1 |
| ListCommonPerf.default | 407 | 386 | 1.05:1 |
| AttachmentMinimalPerf.default | 85 | 82 | 1.04:1 |
| FlexMinimalPerf.default | 157 | 151 | 1.04:1 |
| SliderMinimalPerf.default | 773 | 744 | 1.04:1 |
| AnimationMinimalPerf.default | 303 | 294 | 1.03:1 |
| CheckboxMinimalPerf.default | 1175 | 1145 | 1.03:1 |
| HeaderMinimalPerf.default | 214 | 207 | 1.03:1 |
| ListWith60ListItems.default | 374 | 362 | 1.03:1 |
| TextAreaMinimalPerf.default | 282 | 274 | 1.03:1 |
| CardMinimalPerf.default | 314 | 308 | 1.02:1 |
| DatepickerMinimalPerf.default | 3739 | 3669 | 1.02:1 |
| DropdownManyItemsPerf.default | 400 | 393 | 1.02:1 |
| HeaderSlotsPerf.default | 487 | 476 | 1.02:1 |
| InputMinimalPerf.default | 545 | 535 | 1.02:1 |
| RosterPerf.default | 1590 | 1565 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2310 | 2266 | 1.02:1 |
| FormMinimalPerf.default | 232 | 229 | 1.01:1 |
| ReactionMinimalPerf.default | 214 | 211 | 1.01:1 |
| CustomToolbarPrototype.default | 1488 | 1477 | 1.01:1 |
| TreeMinimalPerf.default | 482 | 478 | 1.01:1 |
| AttachmentSlotsPerf.default | 654 | 651 | 1:1 |
| DialogMinimalPerf.default | 445 | 445 | 1:1 |
| DropdownMinimalPerf.default | 1442 | 1448 | 1:1 |
| EmbedMinimalPerf.default | 1883 | 1877 | 1:1 |
| ListMinimalPerf.default | 306 | 306 | 1:1 |
| MenuMinimalPerf.default | 511 | 513 | 1:1 |
| RadioGroupMinimalPerf.default | 260 | 261 | 1:1 |
| TableMinimalPerf.default | 232 | 232 | 1:1 |
| VideoMinimalPerf.default | 444 | 443 | 1:1 |
| AlertMinimalPerf.default | 160 | 162 | 0.99:1 |
| DividerMinimalPerf.default | 199 | 201 | 0.99:1 |
| MenuButtonMinimalPerf.default | 947 | 957 | 0.99:1 |
| TableManyItemsPerf.default | 1095 | 1109 | 0.99:1 |
| ButtonOverridesMissPerf.default | 634 | 647 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 710 | 722 | 0.98:1 |
| ListNestedPerf.default | 322 | 329 | 0.98:1 |
| ProviderMergeThemesPerf.default | 650 | 664 | 0.98:1 |
| TooltipMinimalPerf.default | 1258 | 1289 | 0.98:1 |
| PopupMinimalPerf.default | 335 | 347 | 0.97:1 |
| TextMinimalPerf.default | 190 | 196 | 0.97:1 |
| BoxMinimalPerf.default | 185 | 192 | 0.96:1 |
| LoaderMinimalPerf.default | 190 | 197 | 0.96:1 |
| ToolbarMinimalPerf.default | 533 | 558 | 0.96:1 |
| AvatarMinimalPerf.default | 102 | 111 | 0.92:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 617 | 5000 | |
| Breadcrumb | mount | 1675 | 1650 | 1000 | |
| Checkbox | mount | 1674 | 1698 | 5000 | |
| CheckboxBase | mount | 1509 | 1467 | 5000 | |
| ChoiceGroup | mount | 2979 | 3034 | 5000 | |
| ComboBox | mount | 660 | 679 | 1000 | |
| CommandBar | mount | 6442 | 6445 | 1000 | |
| ContextualMenu | mount | 11414 | 11704 | 1000 | |
| DefaultButton | mount | 798 | 814 | 5000 | |
| DetailsRow | mount | 2215 | 2214 | 5000 | |
| DetailsRowFast | mount | 2203 | 2232 | 5000 | |
| DetailsRowNoStyles | mount | 2063 | 1999 | 5000 | |
| Dialog | mount | 2780 | 2708 | 1000 | |
| DocumentCardTitle | mount | 226 | 241 | 1000 | |
| Dropdown | mount | 2014 | 2007 | 5000 | |
| FocusTrapZone | mount | 1112 | 1153 | 5000 | |
| FocusZone | mount | 1082 | 1055 | 5000 | |
| GroupedList | mount | 41928 | 41886 | 2 | |
| GroupedList | virtual-rerender | 18046 | 20107 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50522 | 50572 | 2 | |
| GroupedListV2 | mount | 227 | 235 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 217 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 229 | 221 | 2 | |
| IconButton | mount | 1117 | 1122 | 5000 | |
| Label | mount | 351 | 344 | 5000 | |
| Layer | mount | 2792 | 2786 | 5000 | |
| Link | mount | 402 | 388 | 5000 | |
| MenuButton | mount | 976 | 958 | 5000 | |
| MessageBar | mount | 21568 | 21645 | 5000 | |
| Nav | mount | 2055 | 2034 | 1000 | |
| OverflowSet | mount | 798 | 777 | 5000 | |
| Panel | mount | 1808 | 1820 | 1000 | |
| Persona | mount | 760 | 741 | 1000 | |
| Pivot | mount | 864 | 878 | 1000 | |
| PrimaryButton | mount | 910 | 919 | 5000 | |
| Rating | mount | 4676 | 4738 | 5000 | |
| SearchBox | mount | 894 | 914 | 5000 | |
| Shimmer | mount | 1890 | 1870 | 5000 | |
| Slider | mount | 1330 | 1340 | 5000 | |
| SpinButton | mount | 3007 | 3007 | 5000 | |
| Spinner | mount | 384 | 380 | 5000 | |
| SplitButton | mount | 1918 | 1829 | 5000 | |
| Stack | mount | 416 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 877 | 850 | 5000 | |
| StackWithTextChildren | mount | 2618 | 2684 | 5000 | |
| SwatchColorPicker | mount | 6268 | 6347 | 5000 | |
| TagPicker | mount | 1435 | 1458 | 5000 | |
| Text | mount | 371 | 379 | 5000 | |
| TextField | mount | 942 | 930 | 5000 | |
| ThemeProvider | mount | 831 | 826 | 5000 | |
| ThemeProvider | virtual-rerender | 574 | 593 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1263 | 1296 | 5000 | |
| Toggle | mount | 624 | 595 | 5000 | |
| buttonNative | mount | 195 | 182 | 5000 |
fabricteam
reviewed
May 6, 2024
fabricteam
reviewed
May 6, 2024
Hotell
reviewed
May 7, 2024
tools/workspace-plugin/src/generators/normalize-package-dependencies/index.ts
Outdated
Show resolved
Hide resolved
Hotell
reviewed
May 7, 2024
Hotell
reviewed
May 7, 2024
Hotell
reviewed
May 7, 2024
Hotell
reviewed
May 7, 2024
|
Besides providing comments in this PR ( some of them are blockers ) we need to bring in this PR #31296 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
radium-v
force-pushed
the
web-components-v3
branch
from
707be68
to
3ba33e2
Compare
radium-v
force-pushed
the
web-components-v3
branch
from
8f49a44
to
cb6fdf3
Compare
Thank you! |
spmonahan
approved these changes
May 10, 2024
This was referenced May 13, 2024
Hotell
approved these changes
May 13, 2024
JustSlone
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks @chrisdholt @radium-v @Hotell @TristanWatanabe @spmonahan and all that helped get this ready to go!
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
fabricteam
reviewed
May 13, 2024
eljefe223
approved these changes
May 13, 2024
🕵 fluentuiv8 No visual regressions between this PR and main |
|
[celebrate] Justin Slone reacted to your message:
…________________________________
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Development was done in a feature branch.
New Behavior
This PR merges the feature branch into master.
Related Issue(s)