Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts-cypress): mitigate esbuild-loader WARNING spam when running cypress tests #31278

Merged
merged 1 commit into from May 13, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 6, 2024

Previous Behavior

image

New Behavior

see PR title

image

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 6, 2024
Copy link

codesandbox-ci bot commented May 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 646 644 5000
Button mount 303 309 5000
Field mount 1151 1132 5000
FluentProvider mount 722 719 5000
FluentProviderWithTheme mount 74 85 10
FluentProviderWithTheme virtual-rerender 34 31 10
FluentProviderWithTheme virtual-rerender-with-unmount 84 79 10
MakeStyles mount 852 857 50000
Persona mount 1748 1751 5000
SpinButton mount 1429 1434 5000
SwatchPicker mount 1521 1545 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell marked this pull request as ready for review May 6, 2024 17:02
@Hotell Hotell requested a review from a team as a code owner May 6, 2024 17:02
@Hotell Hotell requested a review from marcosmoura May 7, 2024 12:15
@Hotell Hotell merged commit d311ddc into microsoft:master May 13, 2024
19 checks passed
@Hotell Hotell deleted the esbuild-loader/fix-warnings-in-v4 branch May 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: heavy webpack warnings logs in all cypress tests
3 participants