Tabster - update Keyborg to 2.6.0 #31266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 628 | 625 | 5000 | |
| Button | mount | 287 | 315 | 5000 | |
| Field | mount | 1144 | 1138 | 5000 | |
| FluentProvider | mount | 701 | 698 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 39 | 38 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 70 | 10 | |
| MakeStyles | mount | 830 | 851 | 50000 | |
| Persona | mount | 1752 | 1700 | 5000 | |
| SpinButton | mount | 1371 | 1396 | 5000 | |
| SwatchPicker | mount | 1476 | 1521 | 5000 |
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 92 | 76 | 1.21:1 |
| AvatarMinimalPerf.default | 126 | 108 | 1.17:1 |
| CardMinimalPerf.default | 328 | 293 | 1.12:1 |
| PortalMinimalPerf.default | 92 | 83 | 1.11:1 |
| RefMinimalPerf.default | 114 | 104 | 1.1:1 |
| CarouselMinimalPerf.default | 272 | 250 | 1.09:1 |
| ChatDuplicateMessagesPerf.default | 156 | 144 | 1.08:1 |
| FlexMinimalPerf.default | 160 | 149 | 1.07:1 |
| FormMinimalPerf.default | 233 | 217 | 1.07:1 |
| LoaderMinimalPerf.default | 199 | 186 | 1.07:1 |
| ProviderMinimalPerf.default | 211 | 197 | 1.07:1 |
| SegmentMinimalPerf.default | 215 | 201 | 1.07:1 |
| HeaderSlotsPerf.default | 481 | 454 | 1.06:1 |
| ListCommonPerf.default | 406 | 383 | 1.06:1 |
| ReactionMinimalPerf.default | 219 | 206 | 1.06:1 |
| SkeletonMinimalPerf.default | 202 | 190 | 1.06:1 |
| HeaderMinimalPerf.default | 209 | 199 | 1.05:1 |
| RadioGroupMinimalPerf.default | 272 | 259 | 1.05:1 |
| IconMinimalPerf.default | 402 | 384 | 1.05:1 |
| AttachmentSlotsPerf.default | 661 | 637 | 1.04:1 |
| DividerMinimalPerf.default | 209 | 201 | 1.04:1 |
| SplitButtonMinimalPerf.default | 2339 | 2239 | 1.04:1 |
| TreeMinimalPerf.default | 493 | 474 | 1.04:1 |
| ButtonSlotsPerf.default | 315 | 305 | 1.03:1 |
| ChatMinimalPerf.default | 446 | 432 | 1.03:1 |
| ChatWithPopoverPerf.default | 198 | 193 | 1.03:1 |
| GridMinimalPerf.default | 185 | 180 | 1.03:1 |
| ImageMinimalPerf.default | 229 | 223 | 1.03:1 |
| ProviderMergeThemesPerf.default | 653 | 635 | 1.03:1 |
| TooltipMinimalPerf.default | 1269 | 1237 | 1.03:1 |
| AnimationMinimalPerf.default | 302 | 295 | 1.02:1 |
| ButtonOverridesMissPerf.default | 651 | 641 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 703 | 688 | 1.02:1 |
| MenuMinimalPerf.default | 497 | 488 | 1.02:1 |
| MenuButtonMinimalPerf.default | 979 | 958 | 1.02:1 |
| PopupMinimalPerf.default | 343 | 337 | 1.02:1 |
| TextMinimalPerf.default | 195 | 191 | 1.02:1 |
| TextAreaMinimalPerf.default | 300 | 295 | 1.02:1 |
| AlertMinimalPerf.default | 161 | 159 | 1.01:1 |
| DatepickerMinimalPerf.default | 3554 | 3516 | 1.01:1 |
| DropdownMinimalPerf.default | 1422 | 1402 | 1.01:1 |
| EmbedMinimalPerf.default | 1886 | 1865 | 1.01:1 |
| InputMinimalPerf.default | 534 | 530 | 1.01:1 |
| LayoutMinimalPerf.default | 200 | 198 | 1.01:1 |
| ListNestedPerf.default | 326 | 323 | 1.01:1 |
| StatusMinimalPerf.default | 391 | 386 | 1.01:1 |
| TableMinimalPerf.default | 231 | 231 | 1:1 |
| CustomToolbarPrototype.default | 1474 | 1468 | 1:1 |
| ButtonMinimalPerf.default | 85 | 86 | 0.99:1 |
| CheckboxMinimalPerf.default | 1110 | 1122 | 0.99:1 |
| DropdownManyItemsPerf.default | 382 | 386 | 0.99:1 |
| LabelMinimalPerf.default | 217 | 220 | 0.99:1 |
| ListMinimalPerf.default | 308 | 310 | 0.99:1 |
| SliderMinimalPerf.default | 744 | 750 | 0.99:1 |
| TableManyItemsPerf.default | 1103 | 1112 | 0.99:1 |
| VideoMinimalPerf.default | 455 | 461 | 0.99:1 |
| DialogMinimalPerf.default | 436 | 443 | 0.98:1 |
| RosterPerf.default | 1542 | 1572 | 0.98:1 |
| ToolbarMinimalPerf.default | 529 | 545 | 0.97:1 |
| BoxMinimalPerf.default | 184 | 192 | 0.96:1 |
| ListWith60ListItems.default | 352 | 370 | 0.95:1 |
| TreeWith60ListItems.default | 87 | 92 | 0.95:1 |
| AccordionMinimalPerf.default | 82 | 87 | 0.94:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size report
Unchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 620 | 631 | 5000 | |
| Breadcrumb | mount | 1682 | 1686 | 1000 | |
| Checkbox | mount | 1698 | 1717 | 5000 | |
| CheckboxBase | mount | 1480 | 1478 | 5000 | |
| ChoiceGroup | mount | 3021 | 2932 | 5000 | |
| ComboBox | mount | 661 | 671 | 1000 | |
| CommandBar | mount | 6546 | 6486 | 1000 | |
| ContextualMenu | mount | 12193 | 12136 | 1000 | |
| DefaultButton | mount | 787 | 779 | 5000 | |
| DetailsRow | mount | 2214 | 2225 | 5000 | |
| DetailsRowFast | mount | 2218 | 2262 | 5000 | |
| DetailsRowNoStyles | mount | 1995 | 2075 | 5000 | |
| Dialog | mount | 2780 | 2616 | 1000 | |
| DocumentCardTitle | mount | 239 | 226 | 1000 | |
| Dropdown | mount | 1974 | 1993 | 5000 | |
| FocusTrapZone | mount | 1138 | 1154 | 5000 | |
| FocusZone | mount | 1087 | 1077 | 5000 | |
| GroupedList | mount | 41547 | 41873 | 2 | |
| GroupedList | virtual-rerender | 18108 | 20106 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50985 | 50747 | 2 | |
| GroupedListV2 | mount | 225 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 216 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 227 | 226 | 2 | |
| IconButton | mount | 1140 | 1136 | 5000 | |
| Label | mount | 333 | 336 | 5000 | |
| Layer | mount | 2791 | 2758 | 5000 | |
| Link | mount | 392 | 396 | 5000 | |
| MenuButton | mount | 995 | 986 | 5000 | |
| MessageBar | mount | 21942 | 21640 | 5000 | |
| Nav | mount | 2018 | 2032 | 1000 | |
| OverflowSet | mount | 782 | 794 | 5000 | |
| Panel | mount | 1826 | 1800 | 1000 | |
| Persona | mount | 709 | 754 | 1000 | |
| Pivot | mount | 925 | 895 | 1000 | |
| PrimaryButton | mount | 883 | 911 | 5000 | |
| Rating | mount | 4680 | 4600 | 5000 | |
| SearchBox | mount | 907 | 909 | 5000 | |
| Shimmer | mount | 1883 | 1925 | 5000 | |
| Slider | mount | 1367 | 1328 | 5000 | |
| SpinButton | mount | 2954 | 2989 | 5000 | |
| Spinner | mount | 398 | 390 | 5000 | |
| SplitButton | mount | 1881 | 1878 | 5000 | |
| Stack | mount | 413 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 862 | 872 | 5000 | |
| StackWithTextChildren | mount | 2660 | 2679 | 5000 | |
| SwatchColorPicker | mount | 6409 | 6435 | 5000 | |
| TagPicker | mount | 1438 | 1416 | 5000 | |
| Text | mount | 379 | 375 | 5000 | |
| TextField | mount | 939 | 946 | 5000 | |
| ThemeProvider | mount | 850 | 835 | 5000 | |
| ThemeProvider | virtual-rerender | 598 | 570 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1301 | 1287 | 5000 | |
| Toggle | mount | 616 | 596 | 5000 | |
| buttonNative | mount | 185 | 190 | 5000 |
mshoho
approved these changes
May 3, 2024
|
The bundle size reporting seems to be really off. The change (microsoft/keyborg#80) has 446B/57B and there is only one instance of keyborg in the app. It cannot possibly result in multiple Kb increase. |
|
yarn.lock seems to be wrong, there is still a mention of 2.5.0 in it. |
I suppose I need to bump keyborg in Tabster first to get rid of the 2.5.0 reference. |
yes, it was the case: #31268 — this is a version with Tabster that has Keyborg 2.6.0 bump and the bundle is fine. |
Hotell
requested changes
May 3, 2024
|
FYI @micahgodbolt we use solely forks for PR's, please follow that next time you create PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update keyborg to 2.6.0 to fix iOS touch bug microsoft/keyborg#79