Upgrade Playwright to 1.44.0 #31205
Merged
Upgrade Playwright to 1.44.0 #31205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tudorpopams
approved these changes
Apr 26, 2024
radium-v
force-pushed
the
users/radium-v/upgrade-playwright
branch
2 times, most recently
from
e39e0dd
to
ddb97a4
Compare
Hotell
reviewed
Apr 29, 2024
Hotell
reviewed
Apr 29, 2024
radium-v
force-pushed
the
users/radium-v/upgrade-playwright
branch
from
ddb97a4
to
9b3f51e
Compare
📊 Bundle size report✅ No changes found |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AttachmentMinimalPerf.default | 83 | 78 | 1.06:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 235 | 203 | 1.16:1 |
| ButtonMinimalPerf.default | 101 | 88 | 1.15:1 |
| TreeWith60ListItems.default | 90 | 80 | 1.13:1 |
| LabelMinimalPerf.default | 229 | 215 | 1.07:1 |
| SkeletonMinimalPerf.default | 204 | 191 | 1.07:1 |
| StatusMinimalPerf.default | 406 | 383 | 1.06:1 |
| DropdownManyItemsPerf.default | 393 | 376 | 1.05:1 |
| FlexMinimalPerf.default | 156 | 149 | 1.05:1 |
| FormMinimalPerf.default | 223 | 212 | 1.05:1 |
| LoaderMinimalPerf.default | 196 | 186 | 1.05:1 |
| MenuMinimalPerf.default | 507 | 482 | 1.05:1 |
| RefMinimalPerf.default | 111 | 106 | 1.05:1 |
| AccordionMinimalPerf.default | 86 | 83 | 1.04:1 |
| BoxMinimalPerf.default | 205 | 198 | 1.04:1 |
| HeaderMinimalPerf.default | 205 | 198 | 1.04:1 |
| AvatarMinimalPerf.default | 103 | 100 | 1.03:1 |
| EmbedMinimalPerf.default | 1898 | 1843 | 1.03:1 |
| HeaderSlotsPerf.default | 480 | 464 | 1.03:1 |
| ListWith60ListItems.default | 366 | 356 | 1.03:1 |
| SegmentMinimalPerf.default | 197 | 191 | 1.03:1 |
| SliderMinimalPerf.default | 759 | 734 | 1.03:1 |
| TextAreaMinimalPerf.default | 280 | 271 | 1.03:1 |
| VideoMinimalPerf.default | 438 | 427 | 1.03:1 |
| AttachmentSlotsPerf.default | 648 | 633 | 1.02:1 |
| CardMinimalPerf.default | 308 | 302 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 152 | 149 | 1.02:1 |
| LayoutMinimalPerf.default | 202 | 199 | 1.02:1 |
| PopupMinimalPerf.default | 351 | 344 | 1.02:1 |
| ProviderMergeThemesPerf.default | 653 | 638 | 1.02:1 |
| RadioGroupMinimalPerf.default | 259 | 255 | 1.02:1 |
| AnimationMinimalPerf.default | 295 | 292 | 1.01:1 |
| ButtonSlotsPerf.default | 320 | 317 | 1.01:1 |
| CarouselMinimalPerf.default | 273 | 269 | 1.01:1 |
| ChatMinimalPerf.default | 442 | 438 | 1.01:1 |
| DatepickerMinimalPerf.default | 3545 | 3509 | 1.01:1 |
| MenuButtonMinimalPerf.default | 960 | 951 | 1.01:1 |
| PortalMinimalPerf.default | 86 | 85 | 1.01:1 |
| ProviderMinimalPerf.default | 203 | 201 | 1.01:1 |
| IconMinimalPerf.default | 391 | 388 | 1.01:1 |
| TextMinimalPerf.default | 193 | 191 | 1.01:1 |
| CustomToolbarPrototype.default | 1478 | 1466 | 1.01:1 |
| TooltipMinimalPerf.default | 1245 | 1236 | 1.01:1 |
| CheckboxMinimalPerf.default | 1106 | 1105 | 1:1 |
| DialogMinimalPerf.default | 442 | 440 | 1:1 |
| DropdownMinimalPerf.default | 1427 | 1425 | 1:1 |
| InputMinimalPerf.default | 546 | 545 | 1:1 |
| ItemLayoutMinimalPerf.default | 690 | 690 | 1:1 |
| SplitButtonMinimalPerf.default | 2275 | 2269 | 1:1 |
| TableMinimalPerf.default | 228 | 229 | 1:1 |
| ButtonOverridesMissPerf.default | 664 | 674 | 0.99:1 |
| ToolbarMinimalPerf.default | 526 | 529 | 0.99:1 |
| ListMinimalPerf.default | 303 | 309 | 0.98:1 |
| RosterPerf.default | 1589 | 1616 | 0.98:1 |
| TreeMinimalPerf.default | 471 | 479 | 0.98:1 |
| ChatWithPopoverPerf.default | 194 | 200 | 0.97:1 |
| DividerMinimalPerf.default | 196 | 203 | 0.97:1 |
| ReactionMinimalPerf.default | 211 | 217 | 0.97:1 |
| TableManyItemsPerf.default | 1082 | 1116 | 0.97:1 |
| AlertMinimalPerf.default | 156 | 163 | 0.96:1 |
| GridMinimalPerf.default | 180 | 187 | 0.96:1 |
| ListCommonPerf.default | 370 | 387 | 0.96:1 |
| ListNestedPerf.default | 301 | 315 | 0.96:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 75 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 615 | 642 | 5000 | |
| Button | mount | 315 | 323 | 5000 | |
| Field | mount | 1118 | 1135 | 5000 | |
| FluentProvider | mount | 712 | 683 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 35 | 36 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 75 | 10 | Possible regression |
| MakeStyles | mount | 867 | 853 | 50000 | |
| Persona | mount | 1752 | 1731 | 5000 | |
| SpinButton | mount | 1406 | 1355 | 5000 | |
| SwatchPicker | mount | 1532 | 1508 | 5000 |
fabricteam
reviewed
May 6, 2024
fabricteam
reviewed
May 6, 2024
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 617 | 646 | 5000 | |
| Breadcrumb | mount | 1684 | 1688 | 1000 | |
| Checkbox | mount | 1707 | 1714 | 5000 | |
| CheckboxBase | mount | 1465 | 1474 | 5000 | |
| ChoiceGroup | mount | 2974 | 3000 | 5000 | |
| ComboBox | mount | 682 | 656 | 1000 | |
| CommandBar | mount | 6481 | 6400 | 1000 | |
| ContextualMenu | mount | 11977 | 11681 | 1000 | |
| DefaultButton | mount | 773 | 782 | 5000 | |
| DetailsRow | mount | 2228 | 2220 | 5000 | |
| DetailsRowFast | mount | 2181 | 2221 | 5000 | |
| DetailsRowNoStyles | mount | 2039 | 2112 | 5000 | |
| Dialog | mount | 2667 | 2681 | 1000 | |
| DocumentCardTitle | mount | 218 | 227 | 1000 | |
| Dropdown | mount | 1997 | 1989 | 5000 | |
| FocusTrapZone | mount | 1141 | 1164 | 5000 | |
| FocusZone | mount | 1119 | 1078 | 5000 | |
| GroupedList | mount | 42166 | 41984 | 2 | |
| GroupedList | virtual-rerender | 18109 | 20486 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50869 | 51512 | 2 | |
| GroupedListV2 | mount | 227 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 207 | 208 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 230 | 2 | |
| IconButton | mount | 1157 | 1089 | 5000 | |
| Label | mount | 335 | 332 | 5000 | |
| Layer | mount | 2719 | 2781 | 5000 | |
| Link | mount | 392 | 402 | 5000 | |
| MenuButton | mount | 986 | 988 | 5000 | |
| MessageBar | mount | 21844 | 21699 | 5000 | |
| Nav | mount | 2050 | 2032 | 1000 | |
| OverflowSet | mount | 785 | 794 | 5000 | |
| Panel | mount | 1822 | 1843 | 1000 | |
| Persona | mount | 746 | 750 | 1000 | |
| Pivot | mount | 880 | 900 | 1000 | |
| PrimaryButton | mount | 909 | 926 | 5000 | |
| Rating | mount | 4711 | 4758 | 5000 | |
| SearchBox | mount | 929 | 923 | 5000 | |
| Shimmer | mount | 1951 | 1899 | 5000 | |
| Slider | mount | 1348 | 1350 | 5000 | |
| SpinButton | mount | 2964 | 2972 | 5000 | |
| Spinner | mount | 391 | 392 | 5000 | |
| SplitButton | mount | 1902 | 1862 | 5000 | |
| Stack | mount | 409 | 409 | 5000 | |
| StackWithIntrinsicChildren | mount | 845 | 879 | 5000 | |
| StackWithTextChildren | mount | 2672 | 2639 | 5000 | |
| SwatchColorPicker | mount | 6448 | 6405 | 5000 | |
| TagPicker | mount | 1444 | 1462 | 5000 | |
| Text | mount | 375 | 369 | 5000 | |
| TextField | mount | 946 | 965 | 5000 | |
| ThemeProvider | mount | 828 | 842 | 5000 | |
| ThemeProvider | virtual-rerender | 590 | 590 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1320 | 1309 | 5000 | |
| Toggle | mount | 615 | 621 | 5000 | |
| buttonNative | mount | 189 | 187 | 5000 |
fabricteam
reviewed
May 6, 2024
Hotell
reviewed
May 13, 2024
packages/react-components/react-components/stories/AccessibilityScenarios/Checkbox.stories.tsx
Outdated
Show resolved
Hide resolved
radium-v
force-pushed
the
users/radium-v/upgrade-playwright
branch
from
26518f4
to
c9304b9
Compare
fabricteam
reviewed
May 13, 2024
radium-v
force-pushed
the
users/radium-v/upgrade-playwright
branch
from
c9304b9
to
3d6b649
Compare
chrisdholt
approved these changes
May 14, 2024
There was a problem hiding this comment.
This looks good to me - I'll defer to @Hotell as required for this specifically given how important this is to the overall build process.
Hotell
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Playwright was locked to version 1.28.1.
New Behavior
Improvements:
playwrightpackage would download the browser binaries duringinstall. This behavior has been removed in favor of installing the binaries separately.Newer versions of Playwright provide many new improvements, such as:
expect().toHaveAttribute()assertion supports boolean attributes