Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bicep registry docs and scripts #87

Merged
merged 4 commits into from
Mar 25, 2023
Merged

Add bicep registry docs and scripts #87

merged 4 commits into from
Mar 25, 2023

Conversation

flanakin
Copy link
Collaborator

🛠️ Description

This PR adds documentation and scripts to support modules that will be published to the Bicep Registry. Splitting the docs and scripts to simplify the PR.

Supports #86

🔬 How has this been tested?

  • 🫰 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests

@flanakin flanakin requested review from a team, ankur-ms, aromano2, MSBrett and tsilvers-ms March 20, 2023 10:07
@flanakin flanakin added Skill: Documentation Documentation updates Skill: Deployment Resource deployment automation via bicep or terraform Needs: Review 👀 PR that is ready to be reviewed labels Mar 20, 2023
flanakin
flanakin commented Mar 20, 2023
View reviewed changes
src/architecture.md Show resolved Hide resolved
src/templates/finops-hub/test/main.test.bicep Outdated Show resolved Hide resolved
@flanakin flanakin linked an issue Mar 20, 2023 that may be closed by this pull request
[Bicep Registry] Scheduled action bicep module for RBAC scopes #86
Closed
@flanakin flanakin requested a review from tsilvers-ms March 23, 2023 07:14
@flanakin flanakin closed this Mar 25, 2023
@flanakin flanakin reopened this Mar 25, 2023
@flanakin flanakin merged commit 845cb63 into dev Mar 25, 2023
@flanakin flanakin deleted the flanakin/dev/br branch March 25, 2023 08:59
@flanakin flanakin added this to the Toolkit v0.1 – Bicep modules for RBAC scopes milestone Apr 5, 2023
flanakin added a commit that referenced this pull request May 17, 2023
@flanakin
Add bicep registry docs and scripts (#87)
2612a6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur-ms ankur-ms Awaiting requested review from ankur-ms

@aromano2 aromano2 Awaiting requested review from aromano2

@MSBrett MSBrett Awaiting requested review from MSBrett MSBrett is a code owner

@tsilvers-ms tsilvers-ms Awaiting requested review from tsilvers-ms

Assignees

@aromano2 aromano2

@tsilvers-ms tsilvers-ms

@ankur-ms ankur-ms

Labels
Needs: Review 👀 PR that is ready to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Skill: Documentation Documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bicep Registry] Scheduled action bicep module for RBAC scopes
4 participants
@flanakin @tsilvers-ms @aromano2 @ankur-ms