Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in an existing Key Vault instance #573

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Feb 3, 2024

πŸ› οΈ Description

Allow reusing a Key Vault instance in hubs

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin requested a review from a team February 3, 2024 21:37
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Feb 3, 2024
@flanakin flanakin added this to the 0.2.1 milestone Feb 3, 2024
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Feb 3, 2024
@flanakin flanakin requested a review from mutansee February 5, 2024 06:26
@flanakin flanakin force-pushed the flanakin/dev/byo-keyvault branch from 9ed03f9 to 5a4aa4a Compare February 5, 2024 10:24
@mutansee
Copy link

mutansee commented Feb 5, 2024

Can we include additional parameter to refer a Key/secret/certificate from the Key Vault ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants