Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create finops-hub template with storage account #21

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Create finops-hub template with storage account #21

merged 17 commits into from
Feb 3, 2023

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Feb 1, 2023

🛠️ Description

Creates a basic finops-hub template that deploys a storage account.

See #1

🔬 How has this been tested?

  • 🫰 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests

@flanakin flanakin added Type: Feature 💎 Idea to improve the product Skill: Deployment Resource deployment automation via bicep or terraform labels Feb 1, 2023
@flanakin flanakin requested a review from a team February 1, 2023 11:17
@flanakin flanakin changed the title Flanakin/hub Create finops-hub template v0.1 Feb 1, 2023
@flanakin flanakin changed the title Create finops-hub template v0.1 Create finops-hub template with storage deployment Feb 1, 2023
@flanakin flanakin mentioned this pull request Feb 1, 2023
Closed
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
flanakin
flanakin commented Feb 1, 2023
View reviewed changes
src/modules/hub.bicep Outdated Show resolved Hide resolved
@flanakin flanakin added the Status: 🔬 Code review Issue is currently in code review with open PRs label Feb 2, 2023
@flanakin flanakin changed the title Create finops-hub template with storage deployment Create finops-hub template with storage account Feb 2, 2023
@flanakin flanakin requested a review from aromano2 February 2, 2023 20:01
@flanakin flanakin merged commit 78cefdf into main Feb 3, 2023
@flanakin flanakin deleted the flanakin/hub branch February 3, 2023 02:17
@flanakin flanakin added this to the v0.0.1 - MVP milestone Feb 5, 2023
@flanakin flanakin removed Type: Feature 💎 Idea to improve the product Status: 🔬 Code review Issue is currently in code review with open PRs labels Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aromano2 aromano2 aromano2 approved these changes

@ankur-ms ankur-ms Awaiting requested review from ankur-ms

@tsilvers-ms tsilvers-ms Awaiting requested review from tsilvers-ms

Assignees
No one assigned
Labels
Skill: Deployment Resource deployment automation via bicep or terraform
Projects
None yet
Milestone
Toolkit v0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@flanakin @aromano2