Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost Optimization Workbook - December update #1207

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Cost Optimization Workbook - December update #1207

wants to merge 3 commits into from

Conversation

arthurclares
Copy link
Collaborator

🛠️ Description

This PR adds updates the workbook
Fixes #1192 #1178 #1169 #1144

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Dec 13, 2024
@arthurclares arthurclares changed the title Workbook - December update Cost Optimization Workbook - December update Dec 13, 2024
flanakin
flanakin approved these changes Dec 14, 2024
View reviewed changes
docs/_resources/changelog.md Outdated Show resolved Hide resolved
@flanakin flanakin added Status: ▶️ Ready Issue is ready for a dev to start work Tool: Workbooks Azure Monitor workbooks Tool: Optimization workbook Cost optimization workbook and removed Needs: Review 👀 PR that is ready to be reviewed labels Dec 14, 2024
@flanakin flanakin added this to the 2024-12 - December milestone Dec 14, 2024
sebassem
sebassem approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebassem sebassem sebassem approved these changes

@flanakin flanakin flanakin approved these changes

Assignees

@flanakin flanakin

@arthurclares arthurclares

Labels
Status: ▶️ Ready Issue is ready for a dev to start work Tool: Optimization workbook Cost optimization workbook Tool: Workbooks Azure Monitor workbooks
Projects
None yet
Milestone
2024-12 - December
Development

Successfully merging this pull request may close these issues.

Cost Optimization Workbook / Add a new tab for change log
3 participants
@arthurclares @flanakin @sebassem