General best practices documentation update #1090
Conversation
nteyan
changed the title
microsoft-github-policy-service
bot
requested review from
arthurclares and
flanakin
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
microsoft-github-policy-service
bot
added
Skill: Documentation
nteyan
changed the title
| @@ -28,6 +29,157 @@ Discover essential FinOps best practices to optimize cost efficiency and governa | |||
|
|
|||
| --- | |||
|
|
|||
| ## Resource inventory summary | |||
There was a problem hiding this comment.
This is not a service. Maybe use "Resource Manager" instead?
| @@ -28,6 +29,157 @@ Discover essential FinOps best practices to optimize cost efficiency and governa | |||
|
|
|||
| --- | |||
|
|
|||
| ## Resource inventory summary | |||
There was a problem hiding this comment.
Move this after ACO so it's sorted alphabetically.
| @@ -28,6 +29,157 @@ Discover essential FinOps best practices to optimize cost efficiency and governa | |||
|
|
|||
| --- | |||
|
|
|||
| ## Resource inventory summary | |||
|
|
|||
| ### Query: Count of all resources | |||
There was a problem hiding this comment.
Is this really necessary? It feels too simple to document. What scenario does this actually address? Fwiw, I think we have a larger effort to document scenarios across the entire BPL, but it's fine if we don't do that right now.
|
|
||
| <br> | ||
|
|
||
| ### Query: Count of all resources per subscription |
There was a problem hiding this comment.
This still feels too simplistic, right? If we think this and the previous one are needed, should we merge both with the next one, which is closer to what I think people are looking for with a resource inventory?
| resources | ||
| | summarize Count=count(id) by subscriptionId | ||
| | order by Count desc |
There was a problem hiding this comment.
Query styling
| resources | |
| | summarize Count=count(id) by subscriptionId | |
| | order by Count desc | |
| Resources | |
| | summarize Count = count(id) by subscriptionId | |
| | order by Count desc |
| resources | ||
| | summarize Count=count(id) by subscriptionId | ||
| | order by Count desc |
There was a problem hiding this comment.
nit: I'm on the fence as to whether we should put sorting in the queries. We don't want unnecessary load on the server. I get it may be useful in some scenarios, but I'd probably leave that to the user to decide on their own unless sorting is critical for the scenario.
| ```kql | ||
| Resources | ||
| | extend type = case( | ||
| type contains 'microsoft.netapp/netappaccounts', 'NetApp Accounts', |
There was a problem hiding this comment.
This is unmaintainable and not technically accurate, if I'm reading it correctly. We should discuss this one.
| resources | ||
| | summarize count() by location |
There was a problem hiding this comment.
Query styling...
| resources | |
| | summarize count() by location | |
| Resources | |
| | summarize Count = count() by location |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
|
@nteyan: you have some new feedback! Please review and resolve all comments and I'll let reviewers know by removing the |
🛠️ Description
This documentation update introduces new queries to summarize the counts of various resources. The aim is to provide users with an overview of their resource inventory, helping them understand the distribution and quantity of resources in their environment.
📷 Screenshots
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?