Fix/shadowrootmode #6933
Merged
Fix/shadowrootmode #6933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
reviewed
Apr 9, 2024
change/@microsoft-fast-ssr-b7eb9d42-4f98-4cae-842d-f8792c26a757.json
Outdated
Show resolved
Hide resolved
KingOfTac
approved these changes
May 23, 2024
chrisdholt
approved these changes
May 23, 2024
spmonahan
commented
May 23, 2024
change/@microsoft-fast-ssr-b7eb9d42-4f98-4cae-842d-f8792c26a757.json
Outdated
Show resolved
Hide resolved
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix: change 'shadowroot' to 'shadowrootmode' to match spec * Change files * Update change/@microsoft-fast-ssr-b7eb9d42-4f98-4cae-842d-f8792c26a757.json --------- Co-authored-by: Nathan Brown <[email protected]> Co-authored-by: Chris Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Changes the
shadowrootattribute on<template>s toshadowrootmodeper the standardized declarative shadow DOM when server rendering components.👩💻 Reviewer Notes
web.dev notes that pre-standardization, Chrome and Edge used the
shadowrootattribute instead. This attribute doesn't work in any current version of the browsers I tested in so I've removed it entirely. This seems a reasonable choice to me since this package is still in beta and the versions of Chrome and Edge that support the non-standard attribute are quite old at this point, however, if it's necessary to support the non-standard attribute I'm happy to do that work but I will need guidance on how to test against older browser versions.📑 Test Plan
I updated relevant tests in the repo and validated the before and after in Edge, Chrome, Safari and Firefox.
This is my test repo.
Before
Edge
Chrome
Firefox
Safari
After
Edge
Chrome
Firefox
Safari
✅ Checklist
General
$ yarn change