Make Playwright tests async #6911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the number of conflicts and our work to close out #6951, we will be closing this PR as it is more of a nice-to-have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR rewrites all Playwright tests in
fast-foundationto be async/parallel.👩💻 Reviewer Notes
The tests may be slower in this mode, which is why they were initially written to be synchronous. However, the synchronous approach has caused issues regarding cleanup between individual tests, as well as flakiness. The async approach is the recommended way to write Playwright tests.
📑 Test Plan
All tests in
fast-foundationshould pass as expected.✅ Checklist
General
$ yarn change⏭ Next Steps
The next step is to migrate all tests to use a standalone harness instead of Storybook. This will improve the performance of each test by reducing page load duration, and will allow us to more comfortably upgrade Storybook for local development.