Upgrade Playwright to 1.41 #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
EisenbergEffect,
chrisdholt,
bheston,
scomea,
KingOfTac and
nicholasrice
as code owners
chrisdholt
approved these changes
Feb 14, 2024
KingOfTac
approved these changes
Feb 21, 2024
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* upgrade playwright to 1.41 * only use one playwright config * remove custom hasAttribute assertion * remove custom toHaveBooleanAttribute assertion * mark flaky tests with test.fixme * replace deprecated shadowroot attributes in fast-style fixture * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
In FAST Foundation:
@playwright/testinfast-foundationandfast-ssrto the latest stable version.hasAttributeandtoHaveBooleanAttributeassertions fromfast-foundationtests.projectsfield from the playwright config infast-foundation(see fix: run Playwright tests in all browsers #6876).test.fixmeto skip them for now (these will be addressed in future PRs).In FAST SSR:
@playwright/testto the latest stable version.shadowrootattributes withshadowrootmodein the fast-styles test fixture. See https://chromestatus.com/feature/6239658726391808👩💻 Reviewer Notes
This is a subset of the work planned in #6876, which was doing way more stuff than one PR should be doing.
📑 Test Plan
All tests for all packages should pass. Tests in
fast-foundationare no longer run in Chromium three times over.✅ Checklist
General
$ yarn change⏭ Next Steps
Once Playwright is updated, I can start separating the tests in
fast-foundationto run them in async mode. Then, we can get tests running properly in Firefox and Webkit.