Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds
tslib
to thenohoist
list in the root-levelpackage.json
. Additionally, it addstslib
as a dependency to bothfast-router
andfast-react-wrapper
(it was previously only a transient dependency).🎫 Issues
Due to this problem in tslib,
tslib
is locked to version2.5.0
infast-ssr
.👩💻 Reviewer Notes
For both
fast-router
andfast-react-wrapper
, I markedtslib
as a dependency since"importHelpers": true
is set in their tsconfigs.I wasn't sure if all packages should be locked to
2.5.0
, sincefast-ssr
is the only one that uses a class private field.📑 Test Plan
All packages should build and pass all tests as expected.
✅ Checklist
General
$ yarn change
⏭ Next Steps
Once we upgrade to TypeScript 5+, we should be able to continue using more recent versions of tslib.