Fix: add code owner permissions to change directory #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scomea
requested review from
awentzel,
chrisdholt and
nicholasrice
as code owners
chrisdholt
requested changes
Jan 2, 2024
chrisdholt
approved these changes
Jan 2, 2024
|
One change we should try - add the directory as the last line in this file with no owners. That should tell GH that there are no owners required for those files. |
KingOfTac
approved these changes
Jan 3, 2024
|
@microsoft-github-policy-service agree company="Qualcomm Innovation Center, inc." |
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* edit change dir * tweak * more change owners * no change owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Code owners that own individual packages can't approve PR's that include change files at the project root. This change gives Owners of the "fast-foundation" package need permissions to the root 'change' folder as well in order to approve pr's with change files.
🎫 Issues
ad-hoc
✅ Checklist
General
$ yarn changeComponent-specific