bug: unmatched div tag in menu-item.template.ts #6848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalrohra
requested review from
EisenbergEffect,
chrisdholt and
nicholasrice
as code owners
bheston
requested changes
Oct 7, 2023
| @mouseover="${(x, c) => x.handleMouseOver(c.event as MouseEvent)}" | ||
| @mouseout="${(x, c) => x.handleMouseOut(c.event as MouseEvent)}" | ||
| > | ||
| <div> |
There was a problem hiding this comment.
The div is an unnecessary wrapper element and should be removed. If the item is in checkbox or radio mode there will be the input-container element which serves the same purpose.
There was a problem hiding this comment.
Okay, understood I have pushed a new commit, thanks for guidance!
bheston
approved these changes
Oct 9, 2023
scomea
approved these changes
Oct 19, 2023
|
Please run |
Looks like the CLA needs to be accepted as well. |
|
@kamalrohra can you please accept the CLA and rebase and push your branch? I will merge this once that's complete. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
There was an unmatched div in on line , This pull request is to address the same bug
🎫 Issues
This pull request is to address the issue #6840
✅ Checklist
General
$ yarn changeComponent-specific