Fix svg imports path resolution for stories #6743
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
Fixes the squiggles for SVG paths in
*.register.ts
and*.stories.ts
files.π©βπ» Reviewer Notes
It seems that combining the
PlaywrightTest
namespace extension with the"*.svg"
module declaration caused the latter to not be picked up, which caused synthetic paths to SVGs to be seen as errors. Splittingglobal.d.ts
into two separate modules fixes this minor inconvenience.π Test Plan
This change should not affect any build or test process.
β Checklist
General
$ yarn change