Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg imports path resolution for stories #6743

Closed
wants to merge 2 commits into from

Conversation

radium-v
Copy link
Collaborator

Pull Request

πŸ“– Description

Fixes the squiggles for SVG paths in *.register.ts and *.stories.ts files.

πŸ‘©β€πŸ’» Reviewer Notes

It seems that combining the PlaywrightTest namespace extension with the "*.svg" module declaration caused the latter to not be picked up, which caused synthetic paths to SVGs to be seen as errors. Splitting global.d.ts into two separate modules fixes this minor inconvenience.

πŸ“‘ Test Plan

This change should not affect any build or test process.

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@radium-v
Copy link
Collaborator Author

@microsoft-github-policy-service agree

@usrrname
Copy link

boink

@radium-v radium-v force-pushed the users/jokreitl/fix-storybook-svg-types branch from 6c70cd2 to ab052a3 Compare February 13, 2024 01:16
@radium-v radium-v self-assigned this Feb 13, 2024
@janechu
Copy link
Collaborator

janechu commented Jun 10, 2024

Closing this, due to #6951 we are only putting in fixes or critical features.

@janechu janechu closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants