-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pip): added working dir to python setup.py exec #914
fix(pip): added working dir to python setup.py exec #914
Conversation
src/Microsoft.ComponentDetection.Detectors/pip/PythonCommandService.cs
Outdated
Show resolved
Hide resolved
Thanks for the contribution. In order for us to be able to accept it, please review the CLA mentioned above @edena-legit |
@microsoft-github-policy-service agree company="Legit Security" |
@melotic anything else? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
=======================================
- Coverage 75.6% 75.0% -0.7%
=======================================
Files 239 239
Lines 10821 10833 +12
Branches 1086 1087 +1
=======================================
- Hits 8188 8125 -63
- Misses 2321 2392 +71
- Partials 312 316 +4 ☔ View full report in Codecov by Sentry. |
@edena-legit looks like the test run is failing with |
@cobya thats weird as it seems it only occurs in windows build, it seems like runs after were ok..? |
#1129 has now handled this 😄 |
Some
setup.py
files might load data from the file's working dir, such as theREADME.md
file. Currently, when parsing asetup.py
file and executing it, the Python command is executed without specifying the working dir.