Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pip): added working dir to python setup.py exec #914

Conversation

edena-legit
Copy link

@edena-legit edena-legit commented Nov 27, 2023

Some setup.py files might load data from the file's working dir, such as the README.md file. Currently, when parsing a setup.py file and executing it, the Python command is executed without specifying the working dir.

@edena-legit edena-legit requested a review from a team as a code owner November 27, 2023 09:24
@edena-legit edena-legit changed the title added working dir to python setup.py exec - might load README.md fix(pip)/added working dir to python setup.py exec Nov 28, 2023
@cobya cobya added type:refactor Refactoring or improving of existing code detector:pip The pip detector labels Nov 29, 2023
@cobya
Copy link
Contributor

cobya commented Nov 30, 2023

Thanks for the contribution. In order for us to be able to accept it, please review the CLA mentioned above @edena-legit

@edena-legit
Copy link
Author

@microsoft-github-policy-service agree company="Legit Security"

@melotic melotic changed the title fix(pip)/added working dir to python setup.py exec fix(pip): added working dir to python setup.py exec Dec 1, 2023
@edena-legit
Copy link
Author

@melotic anything else?

@edena-legit
Copy link
Author

@cobya

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.0%. Comparing base (2de3cc0) to head (5e0ad0d).
Report is 11 commits behind head on main.

Files Patch % Lines
...ft.ComponentDetection.Common/PathUtilityService.cs 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #914     +/-   ##
=======================================
- Coverage   75.6%   75.0%   -0.7%     
=======================================
  Files        239     239             
  Lines      10821   10833     +12     
  Branches    1086    1087      +1     
=======================================
- Hits        8188    8125     -63     
- Misses      2321    2392     +71     
- Partials     312     316      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya
Copy link
Contributor

cobya commented Dec 19, 2023

@edena-legit looks like the test run is failing with NullReferenceException: Object reference not set to an instance of an object. if you could please take a look

@cobya cobya added the status:waiting-on-response Waiting on a response/more information from the user label Dec 19, 2023
@edena-legit
Copy link
Author

edena-legit commented Mar 5, 2024

@edena-legit looks like the test run is failing with NullReferenceException: Object reference not set to an instance of an object. if you could please take a look

@cobya thats weird as it seems it only occurs in windows build, it seems like runs after were ok..?

@cobya
Copy link
Contributor

cobya commented May 23, 2024

#1129 has now handled this 😄

@cobya cobya closed this May 23, 2024
@edena-legit edena-legit deleted the fix(pip)/add-working-dir-to-setup-py-exec branch June 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:pip The pip detector status:waiting-on-response Waiting on a response/more information from the user type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants