Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[CloudAdapter] Port CloudAdapter to Java #1296

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

ldardick
Copy link

@ldardick ldardick commented Jul 14, 2021

Fixes #1222
Fixes #1266

Description

As the CloudAdapter component was migrated to C#, it should be added in Java with all supporting classes and make the necessary changes in the existing code to support the CloudAdapter component.

Specific Changes

  • Add CloudAdapter component and all supporting classes
  • Add CloudAdapter Tests
  • Add mockito in bot-integration-core
  • Add CloudAdapterWithErrorHandler which inherits from CloudAdapter used by some Java samples
  • Add getCloudAdapter in BotDependencyConfiguration to return a CloudAdapterWithErrorHandler
  • Add InvokeResponse and TypedInvokeResponse to bot-schema, assign old ones as deprecated
  • Relocate BotFrameworkClient to bot-connector to have parity with JS
  • Fix Checkstyle issues

Testing

mvn clean install passing correctly
image

@ghost
Copy link

ghost commented Jul 14, 2021

CLA assistant check
All CLA requirements met.

@ldardick
Copy link
Author

We added additional commits with the stabilization work done on the implementation of CloudAdapter

Specific changes

  • Added a REST Controller for CloudAdapter
  • Added CloudAdapterWithInspection
  • Fixed return types for CompleatableFuture causing a NullPointerException
  • Fixed string comparisons
  • Fixed incorrect recursive call
  • Implemented UserTokenAccess static class to grant CloudAdapter access to an instance of UserTokenProvider
  • Added unit tests for UserTokenAccess
  • Added test cases for ParameterizedBotFrameworkAuthentication

Please let us know if you have any question

@johnmiroki
Copy link

Any updates? It's been almost a year and I wonder what's keeping it from merging?

@johnmiroki
Copy link

@ldardick Hi Dick, I was wondering if you could help me understand: 1. What problem does CloudAdapter try to solve instead of BotFrameworkAdapter? 2. Why hasn't this PR been reviewed and merged after over a year? Appreciate it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Update TeamsInfo to support CloudAdapter (#5728) Port C# CloudAdapter code to Java
5 participants