Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system level testing which can be run locally and in C-ACI #166

Merged
merged 86 commits into from
Oct 31, 2024

Conversation

DomAyre
Copy link
Collaborator

@DomAyre DomAyre commented Oct 17, 2024

To be down-streamed to forks.

  • Adds a docker-compose service for the CCF sandbox which can be run locally and will be runnable in ACI. This separation will make subbing other CCF deployments (local/mccf/azure-cleanroom/etc.) trivial
  • Adds makefile targets to bring the service up and down and then KMS code/constitution etc. can be applied.
  • Tests use these to spin up KMS's then tests endpoints

Todo:

  • Add more scenarios for all endpoints
  • Implement setting up KMS constitution including test JWT issuer
  • Implement running in ACI

UPDATE: deferring for future PR

  • Handle flakiness in deploying KMS to C-ACI CCF network
  • Add a cleanup workflow for C-ACI deployments
  • Add tests for good and bad attestations
  • Add tests for live attestations
  • Add tests for unwrapKey

Issues found so far (currently more nitpicks and probably aren't blockers):

@DomAyre DomAyre marked this pull request as draft October 17, 2024 10:13
@DomAyre DomAyre changed the title Add system level testing which can be run locally and C-ACI Add system level testing which can be run locally and in C-ACI Oct 17, 2024
@DomAyre
Copy link
Collaborator Author

DomAyre commented Oct 29, 2024

Since running in ACI for CI is a bit flaky and we don't want to block fixing the issues, I suggest we merge this as is @beejones if you're happy with this?

@beejones beejones merged commit b9b8f35 into main Oct 31, 2024
13 checks passed
@beejones beejones deleted the system-tests branch October 31, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants