Fix built image id output for subsequent builds #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipfalkner
force-pushed
the
bugfix/docker-task-built-images-wrong-after-multiple-builds
branch
from
0de7b20
to
e3d0d79
Compare
philipfalkner
force-pushed
the
bugfix/docker-task-built-images-wrong-after-multiple-builds
branch
from
e3d0d79
to
5f3d047
Compare
philipfalkner
requested review from
v-mohithgc and
v-schhabra
and removed request for
a team
philipfalkner
force-pushed
the
bugfix/docker-task-built-images-wrong-after-multiple-builds
branch
2 times, most recently
from
d4aa33b
to
1bea6c7
Compare
philipfalkner
force-pushed
the
bugfix/docker-task-built-images-wrong-after-multiple-builds
branch
from
1bea6c7
to
3e34025
Compare
For the first `docker build` task in a job, DOCKER_TASK_BUILT_IMAGES is correct. But for subsequent builds, instead of appending the new image's hash it was duplicating the list, e.g. - after first build: firstBuildId - after second build: firstBuildId;firstBuildId - after third build: firstBuildId;firstBuildId;firstBuildId;firstBuildId - etc. Instead we append the new image hash, as was seemingly the original intention. So now: - after first build: firstBuildId - after second build: firstBuildId;secondBuildId - after third build: firstBuildId;secondBuildId;thirdBuildId - etc.
philipfalkner
force-pushed
the
bugfix/docker-task-built-images-wrong-after-multiple-builds
branch
from
3e34025
to
0904353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the first
docker buildtask in a job, DOCKER_TASK_BUILT_IMAGES is correct. But for subsequent builds, instead of appending the new image's hash it was duplicating the list, e.g.Solution
Instead we append the new image hash, as was seemingly the original intention. So now: