Update distributed group chat example to use streaming API calls as well #4440
Conversation
Signed-off-by: Mohammad Mazraeh <[email protected]>
Signed-off-by: Mohammad Mazraeh <[email protected]>
| @@ -573,7 +573,6 @@ async def create_stream( | |||
| json_output: Optional[bool] = None, | |||
| extra_create_args: Mapping[str, Any] = {}, | |||
| cancellation_token: Optional[CancellationToken] = None, | |||
| *, | |||
There was a problem hiding this comment.
@jackgerrits do we need this here? Can I possibly be breaking anything by removing it?
I have added the max_consecutive_empty_chunk_tolerance to the ChatCompletionClient and it's implementations and had to remove this * as it was raising type check errors (in theory non named parameters, the *, should be after the named parameters, but I was getting pyright and mypy errors for it complaining about number of arguments in the overriden methods ...
There was a problem hiding this comment.
I think we might need to put the * before tools, both in the interface and the implementations. @jackgerrits
There was a problem hiding this comment.
This should be a separate PR.
There was a problem hiding this comment.
all extra params should come after the * to avoid too many positional params
MohMaz
changed the title
|
@ekzhu can you please review when you got a chance? |
|
@victordibia FYI |
|
@MohMaz @jackgerrits this PR is a bit stall. Shall we first fix the |
Why are these changes needed?
Making distributed group chat example include a streaming API integration with the UI
Related issue number
Checks