Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GroupChatManager async run throws an exception if no eligible speaker #4283

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

leryor
Copy link

@leryor leryor commented Nov 20, 2024

Why are these changes needed?

The Autogen introduced an async implementation for the nested chats in v0.2.35, but it currently has an issue with finishing conversation. It rises an exception NoEligibleSpeaker as a signal that the nested chat has finished but it doesn't handle properly so the exception interrupts the whole agentic flow.

To fix the issue, the exception should be handled in GroupChatManager:a_run_chat() in the same way as the synchronous version does GroupChatManager:run_chat().

Related issue number

Checks

@leryor leryor changed the title fix: GroupChatManager async run throw exception if no eligible speaker fix: GroupChatManager async run throws an exception if no eligible speaker Nov 20, 2024
@ilia-shutov-tfs
Copy link

Thank you @orlov332 for a fix! Without this fix, we can't use autogen in asynchronous way (From Python code perspective)

@rysweet rysweet requested a review from ekzhu November 20, 2024 23:59
@ekzhu ekzhu merged commit 2d52bbc into microsoft:0.2 Nov 21, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants