fix: GroupChatManager async run throws an exception if no eligible speaker #4283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Autogen introduced an async implementation for the nested chats in v0.2.35, but it currently has an issue with finishing conversation. It rises an exception
NoEligibleSpeaker
as a signal that the nested chat has finished but it doesn't handle properly so the exception interrupts the whole agentic flow.To fix the issue, the exception should be handled in
GroupChatManager:a_run_chat()
in the same way as the synchronous version doesGroupChatManager:run_chat()
.Related issue number
Checks