Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable embedding_function in RetrieveUserProxyAgent to create initial… #4183

Closed
wants to merge 1 commit into from

Conversation

bryant-nn
Copy link

… vector_db

Why are these changes needed?

Current RetrieveUserProxyAgent doesn't create initial vector_db with embedding_function, which always cause "No content embedding is provided. Will use the VectorDB's embedding function to generate the content embedding." wanring.

Related issue number

Checks

@bryant-nn bryant-nn closed this Nov 14, 2024
@bryant-nn bryant-nn reopened this Nov 14, 2024
@bryant-nn
Copy link
Author

@microsoft-github-policy-service agree

@thinkall
Copy link
Collaborator

Hi @bryant-nn , thank you for the PR. The embeddings will be computed by the vector db. Could you share a complete code snippet for reproducing the issue? Thanks.

@thinkall thinkall added rag retrieve-augmented generative agents 0.2 Issues which are related to the pre 0.4 codebase labels Nov 14, 2024
@thinkall thinkall self-assigned this Nov 14, 2024
@bryant-nn
Copy link
Author

Hi @bryant-nn , thank you for the PR. The embeddings will be computed by the vector db. Could you share a complete code snippet for reproducing the issue? Thanks.

I'm very sorry. I initially thought the sentence 'No content embedding is provided. Will use the VectorDB's embedding function to generate the content embedding.' meant that the VectorDB's default embedding function (all-MiniLM-L6-v2) would be used to create the vector_db. However, I found that in Collection.py, it actually utilizes _embedding_function. Sorry for the confusion.

@bryant-nn bryant-nn closed this Nov 14, 2024
@bryant-nn bryant-nn deleted the 0.2 branch November 14, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase rag retrieve-augmented generative agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants