Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAP] Abstraction of actor_connector to go along with runtime factory and runtime abstraction #3296

Merged
merged 42 commits into from
Oct 22, 2024

Conversation

rajan-chari
Copy link
Contributor

@rajan-chari rajan-chari commented Aug 5, 2024

Why are these changes needed?

AutoGen CAP comes with a default runtime, that's ready to use out of the box, to make it easy to start building Agents in minutes. However, different use cases and environments may require their own runtimes to host AutoGen CAP Agents. Runtime factories were added to make it easy to create new runtimes.

Along with runtime factories runtimes were also abstracted so that Agents/Actors can switch to different runtime implementations as needed.

This PR introduces and abstraction for agent connectors since they will depend on the needs of each runtime. Default implementation is also provided to make it super easy to start building Agents with AutoGen CAP.

Related issue number

Checks

Copy link

gitguardian bot commented Aug 5, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404695 Triggered Generic High Entropy Secret 3357b3e test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@rajan-chari rajan-chari changed the title Rajan/cap factory [CAP] Abstraction of actor_connector to go along with runtime factory and runtime abstraction Aug 7, 2024
Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rajan-chari . I saw you renamed some filenames from upper cases to lower cases, would you like to rename others?

@rajan-chari rajan-chari marked this pull request as draft August 8, 2024 16:51
@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:26
@jackgerrits jackgerrits added the 0.2 Issues which are related to the pre 0.4 codebase label Oct 4, 2024
@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 12, 2024

Hi Rajan,
we've rebased and updated the branch for you. If you are still considering bringing this PR forward please go ahead and update and mark as ready for review. You may also consider having a closer look at 0.4 which has moved to an event-driven actor model. If you are not going to finish this PR please go ahed and close it.

@rajan-chari
Copy link
Contributor Author

Hi Rajan, we've rebased and updated the branch for you. If you are still considering bringing this PR forward please go ahead and update and mark as ready for review. You may also consider having a closer look at 0.4 which has moved to an event-driven actor model. If you are not going to finish this PR please go ahed and close it.

Hi Ryan,
I will update the PR and mark it as ready for review in a short while.

@rajan-chari rajan-chari marked this pull request as ready for review October 21, 2024 06:38
@thinkall thinkall merged commit 1c5baf0 into microsoft:0.2 Oct 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants