-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook optional user input #2961
base: 0.2
Are you sure you want to change the base?
Notebook optional user input #2961
Conversation
… be able to pass the role for the summarizing prompt
… be able to pass the role for the summarizing prompt, minor docstring adjustments
Co-authored-by: Chi Wang <[email protected]>
No idea what this file was about
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10404662 | Triggered | Generic CLI Secret | eff19ac | .github/workflows/dotnet-release.yml | View secret |
10404662 | Triggered | Generic CLI Secret | e973ac3 | .github/workflows/dotnet-release.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
I think there are some base branch discrepancies, my commit seems to be making changes despite me fetching main and just adding the notebook file. I've tried a few times to ensure the commit is clean, and its still these 2 files for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lines that make this code not safe, example:
llm_config = {"config_list": [{"model": "mock", "api_key": "mock"}]}
one option:
llm_config = {
"config_list": [
{
"model": os.getenv("MODEL_NAME"),
"api_key": os.getenv("API_KEY")
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MarianoMolina we've rebased and updated this branch for you - have a look at the remaining unresolved reviews and green the CI and we can get this reviewed and merged for you. |
@MarianoMolina - second notice - think this is close - please have a look and make some updates and we can move toward merging. |
Why are these changes needed?
I've noticed a few threads online asking about how to enable the agents to ask for user input, so I created this notebook that uses a similar StateFlow example to other ChatGroup notebooks, but adds a keyphrase to the system prompts and checks for it in the speaker_selection_method() to optionally ask the user for feedback if the agent needs help.
Related issue number
Answers: #1288
Checks