get RegisterAgentTypeRequest working

microsoft · Nov 14, 2024 · 89ffbca · 89ffbca
1 parent 32f5c42
commit 89ffbca
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 18 deletions.
diff --git a/dotnet/samples/Hello/Backend/appsettings.json b/dotnet/samples/Hello/Backend/appsettings.json
@@ -1,14 +1,8 @@
 {
-    "AllowedHosts": "*",
-    "Kestrel": {
-      "EndpointDefaults": {
-        "Protocols": "Http2"
-      }
-    },
-    "AllowedHosts": "*",
-    "Kestrel": {
-      "EndpointDefaults": {
-        "Protocols": "Http2"
-      }
+  "AllowedHosts": "*",
+  "Kestrel": {
+    "EndpointDefaults": {
+      "Protocols": "Http2"
     }
   }
+}
diff --git a/dotnet/samples/Hello/HelloAgent/Program.cs b/dotnet/samples/Hello/HelloAgent/Program.cs
@@ -15,11 +15,11 @@
 // step 4: send a message to the agent
 
 // step 5: wait for the agent runtime to shutdown
-var app = await AgentsApp.PublishMessageAsync("HelloAgents", new NewMessageReceived
-{
-    Message = "World"
-}, local: true);
-
+// var app = await AgentsApp.PublishMessageAsync("HelloAgents", new NewMessageReceived
+// {
+//     Message = "World"
+// }, local: true);
+var app = await AgentsApp.StartAsync();
 await app.WaitForShutdownAsync();
 
 namespace Hello

diff --git a/dotnet/src/Microsoft.AutoGen/Agents/Services/Grpc/GrpcGateway.cs b/dotnet/src/Microsoft.AutoGen/Agents/Services/Grpc/GrpcGateway.cs
@@ -147,6 +147,7 @@ private async ValueTask RegisterAgentTypeAsync(GrpcWorkerConnection connection,
                 Success = true
             }
         };
+        await connection.ResponseStream.WriteAsync(response).ConfigureAwait(false);
     }
     private async ValueTask DispatchEventAsync(CloudEvent evt)
     {

diff --git a/python/packages/autogen-core/src/autogen_core/application/_worker_runtime.py b/python/packages/autogen-core/src/autogen_core/application/_worker_runtime.py
@@ -643,7 +643,7 @@ async def factory_wrapper() -> T:
 
     async def _process_register_agent_type_response(self, response: agent_worker_pb2.RegisterAgentTypeResponse) -> None:
         future = self._pending_requests.pop(response.request_id)
-        if response.HasField("error"):
+        if response.HasField("error") and response.error:
             future.set_exception(RuntimeError(response.error))
         else:
             future.set_result(None)
@@ -728,7 +728,7 @@ async def add_subscription(self, subscription: Subscription) -> None:
 
     async def _process_add_subscription_response(self, response: agent_worker_pb2.AddSubscriptionResponse) -> None:
         future = self._pending_requests.pop(response.request_id)
-        if response.HasField("error"):
+        if response.HasField("error") and response.error:
             future.set_exception(RuntimeError(response.error))
         else:
             future.set_result(None)