Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write output to stdout #73

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jenshnielsen
Copy link
Contributor

Writing output to stdout breaks the usage of artifacts-keyring with the keyring CLI since it is impossible to discriminate
between the output of the CLI and other text written to stdout.

See astral-sh/uv#3260 as an example where this is an issue but note that this also affects using a system wide install of keyring as a backend with pip.

Writing output to stdout breaks the usage
of artifacts-keyring with the keyring CLI
since it is impossible to discriminate
between the output of the CLI and other
text writen to stdout.
@embetten
Copy link
Contributor

embetten commented May 2, 2024

This looks reasonable to me - thank you for your contributions. We will do some validations before merging

@PanTheDev
Copy link

Will this be merged and released soon? It's a pain to retry auth because it randomly fails because of this issue.

@jenshnielsen
Copy link
Contributor Author

@embetten Any chance this could be merged and released soon? It would make our work flow so much easier with azure artifacts

Copy link
Contributor

@embetten embetten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified - LGTM

@embetten embetten merged commit c87242b into microsoft:master Jun 17, 2024
1 check passed
@embetten embetten mentioned this pull request Jun 17, 2024
@jenshnielsen jenshnielsen deleted the write_to_std_err branch June 18, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants