-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OAuth2Manager] Remove APIs for Implicit grant type #4979
Open
akanpatel2206
wants to merge
3
commits into
main
Choose a base branch
from
user/akanpatel2206/OAuth2Manager_RemoveImplicit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[OAuth2Manager] Remove APIs for Implicit grant type #4979
akanpatel2206
wants to merge
3
commits into
main
from
user/akanpatel2206/OAuth2Manager_RemoveImplicit
+12
−341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanpatel2206
requested review from
AjitSurana,
godlytalias,
jonwis,
ayushjai30,
Saharsh979 and
Hemantxk
December 17, 2024 09:51
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
godlytalias
reviewed
Dec 18, 2024
godlytalias
approved these changes
Dec 18, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Saharsh979
approved these changes
Dec 19, 2024
ayushjai30
reviewed
Dec 19, 2024
ayushjai30
approved these changes
Dec 19, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing APIs added for Implicit grant type suggested by security review.
Implicit grant type is not the recommended way to perform OAuth2.0. Authorization code grant type should be used.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.