Unpackaged App CTA compliance code changes #4927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlytalias
reviewed
Dec 3, 2024
| STDMETHODIMP_(HRESULT __stdcall) NotificationListener::GetAppProcessName( | ||
| _Out_ HSTRING* appProcessName) noexcept try | ||
| { | ||
| auto lock{ m_lock.lock_shared() }; |
There was a problem hiding this comment.
Is there any reason we are acquiring lock here? We're just reading m_processName here and it is not updated after initialization of the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are done to support CTA compliance for unpackaged apps using notifications. For CTA we need to attribute data used by unpackaged apps for notifications in SRUM DB. Since unpackaged app does not have an identity (e.g - AppUserModuleId). SRUM uses ProcessName to attribute data to unpackaged apps
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.