Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WPF sample app that uses WinAppSDK #334

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JesseCol
Copy link
Collaborator

@JesseCol JesseCol commented Apr 20, 2024

Description

Please include a summary of the change and/or which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Target Release

Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.

Checklist

  • Samples build and run using the Visual Studio versions listed in the Windows development docs.
  • Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
  • Samples set the minimum supported OS version to Windows 10 version 1809.
  • Samples build clean with no warnings or errors.
  • [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
  • If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
  • I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

@JesseCol JesseCol changed the title User/jessecol/wpf island app Add a WPF sample app that uses WinAppSDK Apr 26, 2024
Changed_from_original_app: These packages are required for Lottie.
FIX BEFORE COMPLETING PR: These packages aren't currently publicly available.
-->
<PackageReference Include="CommunityToolkit.WinAppSDK.LottieIsland" Version="0.1.1-prerelease.2" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesseCol, can you check with Geoffrey whether this is the correct Lottie NuGet package that he's assembled?

FIX BEFORE COMPLETING PR: These packages aren't currently publicly available.
-->
<PackageReference Include="CommunityToolkit.WinAppSDK.LottieIsland" Version="0.1.1-prerelease.2" />
<PackageReference Include="CommunityToolkit.WinUI.Lottie" Version="8.0.230818-rc-FHL.4.gb41d8fdcc0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We don't want to pull in WinUI Lottie, just WinAppSDK.

is not set in this file: Microsoft.InteractiveExperiences.Common.targets
Changed_from_original_app
The lowest version of Windows that WinAppSDK supports is 17763.
But Lottie requires Windows 10.0.19041.0 or higher, so we target this one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesseCol, WinAppSDK Lottie only requires RS5 (the same as the rest of WASDK). Let's follow-up on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants