Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iconography: Add Tags to Icons #1705

Open
Zakariathr22 opened this issue Dec 14, 2024 · 3 comments · May be fixed by #1706
Open

Iconography: Add Tags to Icons #1705

Zakariathr22 opened this issue Dec 14, 2024 · 3 comments · May be fixed by #1706
Labels
sample enhancement Requests for new samples or changes to an existing page

Comments

@Zakariathr22
Copy link
Contributor

Zakariathr22 commented Dec 14, 2024 •
edited
Loading

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

On the iconography page, I used the tag search feature that was recently introduced in the latest update. I noticed that many icons still lack associated tags. It would be a significant improvement to add tags to all icons, as this would enhance searchability and make the feature more useful.
@Zakariathr22 Zakariathr22 linked a pull request Dec 14, 2024 that will close this issue
Open
3 tasks
@Jay-o-Way
Copy link
Contributor

Hey @Zakariathr22, I would consider this a continuation of issue #1544 or PR #1562. Just saying :) As Andrew said:

I added tags to 400 icons and didn't (couldn't) add tags to all >1400 icons. It takes too much time and patience. 😅

Also in that PR:

for adding tags you dont need to write them by yourself, in this case we can use ChatGPT :)

@Zakariathr22
Copy link
Contributor Author

Zakariathr22 commented Dec 14, 2024 •
edited
Loading

@Jay-o-Way
Do you think it would be better to close this and link #1706 to the issue and the PR you mentioned earlier only?

@Jay-o-Way
Copy link
Contributor

Nope this is good the way it is 👍🏻

@karkarl karkarl added sample enhancement Requests for new samples or changes to an existing page and removed needs-triage labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sample enhancement Requests for new samples or changes to an existing page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance search functionality by adding tags to icons Zakariathr22/WinUI-Gallery
3 participants
@karkarl @Jay-o-Way @Zakariathr22