Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WTH Core] Correct GitHub naming and broken link #322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codebytes
Copy link
Contributor

Fix capitalization for GitHub Actions
Correct broken link (difference in folder name and link name) on case sensitive file systems.

@jrzyshr jrzyshr requested a review from plzm December 9, 2021 21:34
@jrzyshr jrzyshr self-requested a review December 9, 2021 21:34
@codebytes
Copy link
Contributor Author

for additional information.
The first commit renames a folder.
On windows, the filesystem in case insensitive and the readme link works fine.
From GitHub, the links for hack 44 doesn't work because the linux filesystem has Github and the link referenced GitHub.

I had to check out the repo in WSL to rename the folder. I also could have from GH itself.

The second commit does a search and replace on Github to GitHub.

@plzm
Copy link
Contributor

plzm commented Dec 10, 2021

Reviewed all the changes. The folder/file renames make sense. The text changes (Github->GitHub) also do and thanks for leaving github (all lower case, e.g. in CLI) as is. LGTM.

@jrzyshr jrzyshr changed the title Correct GitHub naming and broken link [WTH Core] Correct GitHub naming and broken link Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants