Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure-static-web-apps-ashy-river-0debb7803.yml #1265

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update azure-static-web-apps-ashy-river-0debb7803.yml #1265

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bcf479
Update azure-static-web-apps-ashy-river-0debb7803.yml
juliamuiruri4 Feb 5, 2024
7ac2f34
Update azure-static-web-apps-ashy-river-0debb7803.yml
juliamuiruri4 Feb 7, 2024
2655545
Update azure-static-web-apps-ashy-river-0debb7803.yml
juliamuiruri4 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/azure-static-web-apps-ashy-river-0debb7803.yml
View file
Open in desktop
@@ -1,5 +1,5 @@
name: Azure Static Web Apps CI/CD

on:
push:
branches:
Expand All @@ -12,6 +12,13 @@ on:
jobs:
build_and_deploy_job:
if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
permissions:
actions: read
checks: write
contents: read
deployments: read
pull-requests: write
security-events: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is the default recommendation but I don't think the token is used for security events for example. Can we reduce this to the minimum needed? From reading this workflow file it looks like it only needs to write back to PR comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alfredodeza - Updated permissions for prs and actions only

runs-on: ubuntu-latest
name: Build and Deploy Job
steps:
Expand Down