-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore skipLibCheck (experiment) #60427
base: main
Are you sure you want to change the base?
Conversation
We're just curious what breaks
@typescript-bot test it |
@RyanCavanaugh Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
Hey @RyanCavanaugh, the results of running the DT tests are ready. Everything looks the same! |
@RyanCavanaugh Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing Everything looks good! |
@@ -10295,7 +10295,7 @@ function skipTypeCheckingWorker( | |||
// If skipLibCheck is enabled, skip reporting errors if file is a declaration file. | |||
// If skipDefaultLibCheck is enabled, skip reporting errors if file contains a | |||
// '/// <reference no-default-lib="true"/>' directive. | |||
return (options.skipLibCheck && sourceFile.isDeclarationFile || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have been "true" to check if it was always on? Or were you looking to try and see if we never did this if things changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was trying to manifest opposite day
@typescript-bot test it |
Hey @RyanCavanaugh, the results of running the DT tests are ready. Everything looks the same! |
@RyanCavanaugh Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
@RyanCavanaugh Here are some more interesting changes from running the user tests suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the user tests suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the user tests suite Details
|
@RyanCavanaugh Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Well, we definitely found some checks that we shouldn't be doing |
@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
@RyanCavanaugh Here are some more interesting changes from running the top 400 repos suite Details
|
Just curious what breaks