fix(57022): Rename of string literal property name doesn't rename all…

… occurences (#57201)
microsoft · May 24, 2024 · af3a61f · af3a61f
1 parent 7ad8f39
commit af3a61f
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -757,7 +757,7 @@ interface PrefixAndSuffix {
  readonly suffixText?: string;
 }
 function getPrefixAndSuffixText(entry: Entry, originalNode: Node, checker: TypeChecker, quotePreference: QuotePreference): PrefixAndSuffix {
- if (entry.kind !== EntryKind.Span && isIdentifier(originalNode)) {
+ if (entry.kind !== EntryKind.Span && (isIdentifier(originalNode) || isStringLiteralLike(originalNode))) {
  const { node, kind } = entry;
  const parent = node.parent;
  const name = originalNode.text;

diff --git a/tests/baselines/reference/renameStringPropertyNames2.baseline.jsonc b/tests/baselines/reference/renameStringPropertyNames2.baseline.jsonc
@@ -0,0 +1,10 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringPropertyNames2.ts ===
+// type Props = {
+// <|[|fooRENAME|]: boolean;|>
+// }
+// 
+// <|let { [|fooRENAME|]: foo/*END SUFFIX*/ }: Props = null as any;|>
+// foo;
+// 
+// let asd: Props = { <|"[|fooRENAME|]"/*RENAME*/: true|> }; // rename foo here
diff --git a/tests/cases/fourslash/renameStringPropertyNames2.ts b/tests/cases/fourslash/renameStringPropertyNames2.ts
@@ -0,0 +1,12 @@
+/// <reference path="fourslash.ts" />
+
+////type Props = {
+//// foo: boolean;
+////}
+////
+////let { foo }: Props = null as any;
+////foo;
+////
+////let asd: Props = { "foo"/**/: true }; // rename foo here
+
+verify.baselineRename("", {});