Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing 3 PRs related to large table updates to 1.0 HF (main) #478

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Syncing 3 PRs related to large table updates to 1.0 HF (main) #478

merged 2 commits into from
Jan 31, 2024

Conversation

dayland
Copy link
Contributor

@dayland dayland commented Jan 24, 2024 •
edited
Loading

@mausolfj mausolfj self-assigned this Jan 30, 2024
mausolfj
mausolfj approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mausolfj mausolfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and approve code changes. did have a question regarding comment on line 129 that may improve readability and understanding if it could be addressed

@dayland dayland merged commit 1868cd0 into main Jan 31, 2024
6 checks passed
@dayland dayland deleted the dayland/large-table-1.0-HF-from-vNext-Dev-PRs branch January 31, 2024 13:18
This was referenced Feb 6, 2024
Closed
Closed
@dayland dayland mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mausolfj mausolfj mausolfj approved these changes

@ryonsteele ryonsteele ryonsteele approved these changes

@asbanger asbanger Awaiting requested review from asbanger asbanger is a code owner

@georearl georearl Awaiting requested review from georearl georearl is a code owner

Assignees

@mausolfj mausolfj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With GPT-4 less than 2mb PDF file Failing - InvalidRequestError maximum context length Chunks too Large
4 participants
@dayland @ryonsteele @mausolfj @dayland-ms