-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ryonsteele/function autoscale #390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lon-tierney
reviewed
Dec 8, 2023
ryonsteele
requested review from
dayland,
georearl and
asbanger
as code owners
December 13, 2023 18:13
dayland
requested changes
Dec 14, 2023
dayland
previously approved these changes
Dec 14, 2023
dayland
previously approved these changes
Dec 15, 2023
…crosoft/PubSec-Info-Assistant into ryonsteele/function-autoscale
lon-tierney
approved these changes
Dec 18, 2023
ArpitaisAn0maly
approved these changes
Dec 19, 2023
ryonsteele
added a commit
that referenced
this pull request
Dec 20, 2023
Ryonsteele/function autoscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Changes Function SKU from S3x5 to S2x2
-Changes Enrichment default instanced from 3 to 1
-Adds CPU metric Autoscale with specific configuration for function and Enrichment
-Refactor Enrichment concurrency and Dequeue default
-Able to handle Functional Tests
-Able to process 170+ Medium to Large PDF's
-Increases function timeout from 1 to 2 hours to allow for processing of larger files for unstructured
The Autoscaler reads CPU and performs Scale up and Down.
When tested with 44 PDF file Finance Dataset and about 30 other large PDF's it scales out as the files begin to trickle through the pipeline.
Once the majority is handed to enrichment the Autoscaler begins to step down back to the default 2 instance count.
Fixes #397
Fixes #405