Merge pull request #438 from microsoft/ryonsteele/6373-aoai-kv-hf

Resolve issue with aoai key reference when not using existing deployment
microsoft · Jan 9, 2024 · ce90232 · ce90232
2 parents 45a02ea + d9b0d90
commit ce90232
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/infra/core/ai/cognitiveservices.bicep b/infra/core/ai/cognitiveservices.bicep
@@ -6,6 +6,7 @@ param customSubDomainName string = name
 param deployments array = []
 param kind string = 'OpenAI'
 param publicNetworkAccess string = 'Enabled'
+param keyVaultName string
 param sku object = {
   name: 'S0'
 }
@@ -36,6 +37,18 @@ resource deployment 'Microsoft.CognitiveServices/accounts/deployments@2023-05-01
   }
 }]
 
+resource keyVault 'Microsoft.KeyVault/vaults@2022-07-01' existing = if (!(empty(keyVaultName))) {
+  name: keyVaultName
+}
+
+resource openaiServiceKeySecret 'Microsoft.KeyVault/vaults/secrets@2019-09-01' = {
+  parent: keyVault
+  name: 'AZURE-OPENAI-SERVICE-KEY'
+  properties: {
+    value: account.listKeys().key1
+  }
+}
+
 output endpoint string = account.properties.endpoint
 output id string = account.id
 output name string = account.name
diff --git a/infra/core/security/keyvault.bicep b/infra/core/security/keyvault.bicep
@@ -5,6 +5,7 @@ param kvAccessObjectId string
 param openaiServiceKey string
 @secure()
 param spClientSecret string 
+param useExistingAOAIService bool
 
 
 
@@ -33,7 +34,7 @@ resource kv 'Microsoft.KeyVault/vaults@2019-09-01' = {
   }
 }
 
-resource openaiServiceKeySecret 'Microsoft.KeyVault/vaults/secrets@2019-09-01' = {
+resource openaiServiceKeySecret 'Microsoft.KeyVault/vaults/secrets@2019-09-01' = if (useExistingAOAIService){
   parent: kv
   name: 'AZURE-OPENAI-SERVICE-KEY'
   properties: {

diff --git a/infra/main.bicep b/infra/main.bicep
@@ -294,6 +294,7 @@ module cognitiveServices 'core/ai/cognitiveservices.bicep' = if (!useExistingAOA
     name: !empty(openAiServiceName) ? openAiServiceName : '${prefix}-${abbrs.openAIServices}${randomString}'
     location: location
     tags: tags
+    keyVaultName: kvModule.outputs.keyVaultName
     sku: {
       name: openAiSkuName
     }
@@ -711,6 +712,7 @@ module kvModule 'core/security/keyvault.bicep' = {
     kvAccessObjectId: kvAccessObjectId
     openaiServiceKey: azureOpenAIServiceKey
     spClientSecret: aadMgmtClientSecret
+    useExistingAOAIService: useExistingAOAIService
   }
 }