Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monaco] Add support for .srt (subtitle) file previewing #32817

Merged
merged 1 commit into from May 14, 2024

Conversation

PesBandi
Copy link
Contributor

Summary of the Pull Request

Adds support for previewing .srt files (Peek and FE dev file preview). They are previewed as plaintext, as suggested by the issue author.

PR Checklist

  • Closes: Preview of .srt files (subtitles) #32769
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

Adds .srt to txtExt in monaco_languages.json.

Validation Steps Performed

Observing

@jaimecbernardo jaimecbernardo merged commit c458087 into microsoft:main May 14, 2024
10 checks passed
@PesBandi PesBandi deleted the filepreview-srt branch May 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants