27292 Add title text to images in high contrast mode [Update Force Gr…

…aph to support high contrast mode] (#36)
microsoft · Jul 23, 2018 · 42a6dd0 · 42a6dd0
1 parent a0c0fdb
commit 42a6dd0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/visual.ts b/src/visual.ts
@@ -688,7 +688,8 @@ module powerbi.extensibility.visual {
                             }
 
                             return ForceGraph.DefaultImage;
-                        }
+                        },
+                        title: (node: ForceGraphNode) => node.name,
                     });
             } else {
                 this.nodes

diff --git a/test/visualBuilder.ts b/test/visualBuilder.ts
@@ -54,6 +54,10 @@ module powerbi.extensibility.visual.test {
             return this.mainElement.children("g.node");
         }
 
+        public get images() {
+            return this.nodes.children("image");
+        }
+
         public get circles() {
             return this.nodes.children("circle");
         }

diff --git a/test/visualTest.ts b/test/visualTest.ts
@@ -355,6 +355,23 @@ module powerbi.extensibility.visual.test {
         });
 
         describe("Accessibility", () => {
+            it("title should be filled for all of images", () => {
+                dataView.metadata.objects = {
+                    nodes: {
+                        displayImage: true,
+                    },
+                };
+
+                visualBuilder.updateFlushAllD3Transitions(dataView);
+
+                visualBuilder.images
+                    .toArray()
+                    .map($)
+                    .forEach((image: JQuery) => {
+                        expect(image.attr("title")).toBeDefined();
+                    });
+            });
+
             describe("High contrast mode", () => {
                 const backgroundColor: string = "#000000";
                 const foregroundColor: string = "#ffff00";