Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2780 #2785

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Issue 2780 #2785

wants to merge 6 commits into from

Conversation

LucGenetier
Copy link
Contributor

No description provided.

@LucGenetier LucGenetier requested a review from a team as a code owner December 18, 2024 13:26
@LucGenetier LucGenetier linked an issue Dec 18, 2024 that may be closed by this pull request
Connectors shouldn't need both HttpClient and uriPrefix #2780
Open
@LucGenetier
Copy link
Contributor Author

✅ No public API change.

@MikeStall
Copy link
Contributor

MikeStall commented Dec 18, 2024 •
edited
Loading 

    protected internal static async Task<T> GetObject<T>(HttpClient httpClient, string message, string uri, string content, CancellationToken cancellationToken, ConnectorLogger logger = null, [CallerMemberName] string callingMethod = "")

can we remove (coming from httpClient now).
Ditto for cases below.

Refers to: src/libraries/Microsoft.PowerFx.Connectors/Tabular/Services/CdpServiceBase.cs:21 in 7a35813. [](commit_id = 7a35813, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author 

    protected internal static async Task<T> GetObject<T>(HttpClient httpClient, string message, string uri, string content, CancellationToken cancellationToken, ConnectorLogger logger = null, [CallerMemberName] string callingMethod = "")

This method is used in CdpDataSource to convert Http responses to POCOs
I don't understand why we'd remove it

In reply to: 2551745584

Refers to: src/libraries/Microsoft.PowerFx.Connectors/Tabular/Services/CdpServiceBase.cs:21 in 7a35813. [](commit_id = 7a35813, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author

✅ No public API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeStall MikeStall MikeStall left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connectors shouldn't need both HttpClient and uriPrefix
2 participants
@LucGenetier @MikeStall