Improve UDF handling in delegation strategy #2699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uyen/filter-function-udf-delegation-strat
|
✅ No public API change. |
rick-nguyen
changed the title
|
✅ No public API change. |
|
✅ No public API change. |
…uyen/filter-function-udf-delegation-strat
…//github.com/microsoft/Power-Fx into rnguyen/filter-function-udf-delegation-strat
src/libraries/Microsoft.PowerFx.Core/Functions/UserDefinedFunction.cs
Outdated
Show resolved
Hide resolved
...osoft.PowerFx.Core/Functions/Delegation/DelegationStrategies/DelegationValidationStrategy.cs
Outdated
Show resolved
Hide resolved
...osoft.PowerFx.Core/Functions/Delegation/DelegationStrategies/DelegationValidationStrategy.cs
Outdated
Show resolved
Hide resolved
|
✅ No public API change. |
rick-nguyen
added
the
Breaking Internals
…//github.com/microsoft/Power-Fx into rnguyen/filter-function-udf-delegation-strat
|
✅ No public API change. |
|
✅ No public API change. |
| [Theory] | ||
| [InlineData( | ||
| "DelegatableUDF(Value: Number):Boolean = Value > 5;", | ||
| "DelegatableUDF2():MyDataSourceTableType = Filter(MyDataSource, DelegatableUDF(Value));", |
There was a problem hiding this comment.
We need to support it at least for non-row scope scenarios. For row-scope scenarios, it gets complicated in translation which we need to design it well.
Using UDF which is non-row scope shouldn't make the parent function call non-delegable. This works today at least which is good.
There was a problem hiding this comment.
For example,
UDF2(Name:Text) = Name;
This UDF2 could be row-scoped or non-row scoped depending in the context it is used.
Filter(Accounts, Name = UDF2(Name)) --> Row scoped
Filter(Accounts, Name = UDF2("")) --> Non-Row scoped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag that allows us to maintain UDF context when visiting UDF call nodes in delegation strategy. This is needed to provide accurate warnings when using UDF inside filter function args.