Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra validation when DateTimeValue(uo) #2589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove extra validation when DateTimeValue(uo) #2589

wants to merge 1 commit into from

Conversation

anderson-joyle
Copy link
Contributor

Issue #2587.

@anderson-joyle anderson-joyle requested a review from a team as a code owner August 13, 2024 17:33
anderson-joyle
anderson-joyle commented Aug 13, 2024
View reviewed changes
src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryUntypedObject.cs
@@ -20,11 +20,6 @@ namespace Microsoft.PowerFx.Functions
{
internal static partial class Library
{
private static bool IsValidDateTimeUO(string s)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsValidDateTimeUO

Introduced at #527

@LucGenetier
Copy link
Contributor

✅ No public API change.

@anderson-joyle anderson-joyle force-pushed the andersonf/2587-uo-to-datetimevalue branch from 140f72e to e28fd4e Compare August 13, 2024 18:28
LucGenetier
LucGenetier approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@LucGenetier LucGenetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anderson-joyle anderson-joyle force-pushed the andersonf/2587-uo-to-datetimevalue branch from e28fd4e to 3852c83 Compare August 14, 2024 19:36
@LucGenetier
Copy link
Contributor

✅ No public API change.

@anderson-joyle anderson-joyle force-pushed the andersonf/2587-uo-to-datetimevalue branch from 3852c83 to 1950e40 Compare August 21, 2024 19:46
@LucGenetier
Copy link
Contributor

✅ No public API change.

@anderson-joyle anderson-joyle force-pushed the andersonf/2587-uo-to-datetimevalue branch from 1950e40 to 8f3b562 Compare August 30, 2024 00:18
@LucGenetier
Copy link
Contributor

✅ No public API change.

@anderson-joyle anderson-joyle force-pushed the andersonf/2587-uo-to-datetimevalue branch from 8f3b562 to d2e6e8b Compare September 3, 2024 19:18
@LucGenetier
Copy link
Contributor

✅ No public API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucGenetier LucGenetier LucGenetier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anderson-joyle @LucGenetier