Limited regular expressions #2504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. My top concern is complexity - but this keeps it simple. |
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Match_Limited.txt
Outdated
Show resolved
Hide resolved
src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Match_Limited.txt
Outdated
Show resolved
Hide resolved
|
Do all positive tests under Match_Limited.txt work in Power Apps? |
| @@ -153,12 +153,12 @@ private static bool ShouldSkipDotNetVersion(ExpressionTestCase testCase, string | |||
| return false; | |||
| } | |||
|
|
|||
| #if false | |||
| #if true | |||
There was a problem hiding this comment.
Remember to revert this back
|
✅ No public API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we GA regular expressions in C# we'd like to have one consistent regular expression language between C# and Canvas. This PR limits regular expressions to common features that are supported, with consistent semantics, by both canonical .NET (used by the C# interpreter) and XRegExp (used by Canvas/JavaScript). It is better to disallow now and bring back with customer demand or as platforms add more support.
.NET Features that are disallowed:
(a\1).(?'name'...and\k'name'.\o(letter o) could be added in the future, but we should avoid\0(zero) which causes backreference confusion.[a-z-[m-n]].