WIP: Adds warning on comparing same FirstNameNode #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No public API change. |
MikeStall
reviewed
Apr 9, 2024
| return false; | ||
| } | ||
|
|
||
| private static bool IsNoOPFirstNameComparison(TexlNode left, TexlNode right) |
There was a problem hiding this comment.
NOTE: I will check the impact of the change with the PowerApps using a private build.
| // Helps warn no op comparison, e.g. Filter(table, ThisRecord.Value = Value)) or Filter(table, Value = Value) | ||
| if (IsNoOPFirstNameComparison(node)) | ||
| { | ||
| _txb.ErrorContainer.EnsureError(DocumentErrorSeverity.Severe, node, TexlStrings.WrnNoOpFieldComparison); |
There was a problem hiding this comment.
Shouldn't it be a warning instead of DocumentErrorSeverity.Severe?
There was a problem hiding this comment.
You are absolutely right! Thanks for catching it...
jas-valgotar
changed the title
|
✅ No public API change. |
jas-valgotar
force-pushed
the
jas/fn-comparison-error
branch
from
827e568 to
e0d9bb3
Compare
|
✅ No public API change. |
lesaltzm
reviewed
Apr 24, 2024
| @@ -4575,4 +4575,8 @@ | |||
| <value>Delegation warning. The result of this argument '{0}' may be truncated for large data sets before being passed to the '{1}' function.</value> | |||
| <comment>Error message when an argument to non-delegable function has possible delegation and resulting rows may be truncated</comment> | |||
| </data> | |||
| <data name="WrnNoOpFieldComparison" xml:space="preserve"> | |||
| <value>This comparison will always be constant. (Always yields true or false). Please consider using 'As' keyword for aliasing scoped variable if this not what you want.</value> | |||
There was a problem hiding this comment.
aliasing isn't a super low-code friendly term. run this by a PM or content person?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a warning when comparing two identical FirstNameNode instances, which could be either global or scoped variables.
This enhancement is particularly beneficial in scenarios involving scoped variables, where it's easy to misunderstand the concept of implicit
ThisRecord.It's important to note that this change is non-breaking, as it only adds a warning without generating an error.