Connectors shouldn't need both HttpClient and uriPrefix #2780

MikeStall · 2024-12-17T05:51:16Z

HttpClient already provides the base address. So we shouldn't also need uriPrefix (which is conceptually just part of the base address).

An additional benefit is that this lets the host fully control the endpoint.

They can pick v1 vs. v2, (will this also lets us revert Make ZenDesk use v2 #2718 and instead defer that responsibility to the host?)
They can call CDP hosted outside of APIM. (this includes localhost)

MikeStall · 2024-12-17T06:01:10Z

This will also flush out other concerns. We extract a connectorName from the uri:

Line 96 in 8d2a190

string connectorName = (parts.Length > 1) ? parts[1] : string.Empty;

we should avoid this because:

Fx.Connectors (client code) shouldn't be having per-connector logic. CDP is supposed to be a standard interface.
we can't always assume the uri implies the connector type.

Worst case - we could still get this information from httpClient.baseAddress.

MikeStall added the Connectors Issues related to connectors. label Dec 17, 2024

MikeStall assigned LucGenetier Dec 17, 2024

MikeStall added the Breaking API label Dec 17, 2024

LucGenetier linked a pull request Dec 18, 2024 that will close this issue

Issue 2780 #2785

Open

Provide feedback