Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msft intune mobile app configuration policy ios #5401

Open
wants to merge 9 commits into
base: Dev
Choose a base branch
from

Conversation

dannyKBjj
Copy link

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Export appears to be working for "settings"
Module is affected by issue microsoft#5396. Replace ` with " in M365TenantConfig.ps1 is your configuration key values contain double quotes. Otherwise, it should work as expected.
@ykuijs
Copy link
Member

ykuijs commented Nov 14, 2024

Same comment as for your other PR:
All of our resources require unit tests (which are also completing successfully) and example files, for example:

Also we need an entry of this new resource in the changelog: https://github.com/microsoft/Microsoft365DSC/blob/Dev/CHANGELOG.md

Could you please add these items to the PR?

create,update and remove examples added
@dannyKBjj
Copy link
Author

Added unit test, examples and updated change log. Hopefully I did it right?!

@ykuijs
Copy link
Member

ykuijs commented Nov 15, 2024

Do not see the updated changelog yet. Could you please check?

Comment on lines 6 to 30
"delegated": {
"read": [
{
"name": "DeviceManagementApps.Read.All"
}
],
"update": [
{
"name": "DeviceManagementApps.ReadWrite.All"
}
]
},
"application": {
"read": [
{
"name": "DeviceManagementApps.Read.All"
}
],
"update": [
{
"name": "DeviceManagementApps.ReadWrite.All"
}
]
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're dealing with Intune assignments, an additional entry for Group.Read.All is required. You can take at the other Intune resources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many blank linkes in there. Please remove them for better readability.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks will sort it out over the weekend

 Group.Read.All permission added to settings.json

Excessive number of blank lines reduced for readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants