Pylint fixups #886

bpkroth · 2024-11-22T02:53:37Z

Pull Request

Additional fixups for the most recent versions of python/pylint.

Converts some quote inconsistency ignores to """ strings
Ignores a Generator typehint issue that changed with 3.13
Adjusts a comment in pyproject.toml to help us track what needs to change after dropping support for 3.8 - Consider dropping support for python 3.8 and/or 3.9 #749.

mlos_bench/mlos_bench/environments/local/local_fileshare_env.py

mlos_bench/mlos_bench/services/remote/azure/azure_vm_services.py

…pport old ones

This reverts commit deaa62e.

pyproject.toml

bpkroth commented Nov 22, 2024

View reviewed changes

mlos_bench/mlos_bench/environments/local/local_fileshare_env.py Outdated Show resolved Hide resolved

bpkroth commented Nov 22, 2024

View reviewed changes

mlos_bench/mlos_bench/services/remote/azure/azure_vm_services.py Outdated Show resolved Hide resolved

bpkroth added 4 commits November 22, 2024 16:43

ignore f-string nested quote diffferences

60ca0c1

ignore generatory typehint advise for modern python while we still su…

eeeb656

…pport old ones

alternative way of ignoring things

deaa62e

Revert "alternative way of ignoring things"

7b7f8f4

This reverts commit deaa62e.

bpkroth force-pushed the pylint-fixups branch from 240cb0b to 7b7f8f4 Compare November 22, 2024 16:45

bpkroth added 3 commits November 22, 2024 16:53

better way of fixing inconsistent quotes

07e36c6

one more

0e2ecea

comments (to help us when deprecating python 3.8)

22d8839

bpkroth commented Nov 22, 2024

View reviewed changes

pyproject.toml Show resolved Hide resolved

bpkroth marked this pull request as ready for review November 22, 2024 17:07

bpkroth requested a review from a team as a code owner November 22, 2024 17:07

bpkroth added low priority Low-priority issue ready for review Ready for review labels Nov 22, 2024

bpkroth enabled auto-merge (squash) November 22, 2024 17:10