Rewrite for named tuples #852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
mlos_bench/mlos_bench/tests/optimizers/toy_optimization_loop_test.py
Outdated
Show resolved
Hide resolved
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
bpkroth
reviewed
Sep 17, 2024
…plement bulk registration for each of them separately
bpkroth
approved these changes
Nov 22, 2024
|
All good now. Thanks for your patience :) |
|
Found a few more issues. Gonna try and tackle them myself. |
…Observations to be plural
bpkroth
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Refactor mlos_core APIs to encapsulate related data fields.
Description
Refactors the mlos_core Optimizer APIs to accept new data types
Observation,Observationsand returnSuggestion, instead of a mess ofTuple[DataFrame, DataFrame, Optional[DataFrame], Optional[DataFrame]]that must be named and checked everywhere.Additionally, this makes it more explicit that
_registeris a bulk operation that is not actually supported currently by the underlying optimizers, though leaves notes on how we can do that in the future.Type of Change
Testing
Usual CI plus some new unit tests for new data type operations.
Additional Notes
A more significant rewrite of named tuple support inside mlos_core.
This is based on comments in #811 as well as conversations with @bpkroth