WIP: Introduce TrialRunner Abstraction #720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit test for bench (not tested)
…e bulk registration (check for is_warm_up)
bpkroth
commented
Sep 23, 2024
| @@ -46,6 +46,16 @@ def __init__( # pylint: disable=too-many-arguments | |||
| self._engine = engine | |||
| self._schema = schema | |||
|
|
|||
| def _save_new_config_data(self, new_config_data: Dict[str, Union[int, float, str]]) -> None: | |||
bpkroth
commented
Sep 23, 2024
| @@ -145,6 +161,7 @@ def get_results_df( | |||
| "tunable_config_id", | |||
| "tunable_config_trial_group_id", | |||
| "status", | |||
| "trial_runner_id", | |||
bpkroth
commented
Sep 23, 2024
| """ID of the TrialRunner.""" | ||
| if not self._trial_runner_id: | ||
| self._trial_runner_id = self.metadata_dict.get("trial_runner_id") | ||
| return self._trial_runner_id |
bpkroth
commented
Sep 23, 2024
bpkroth
added a commit
that referenced
this pull request
Oct 1, 2024
Refactors tests in preparation for testing for #720. Adds `status()` output for MockEnv as well, though with a pending FIXME on improving the Status type in the status output that we'll address in a future PR.
…to trial-runner-abstraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step in adding support for parallel trial execution #380.
Here we separate out the running of an individual trial to a single class - TrialRunner.
Multiple TrialRunners are instantiated at CLI invocation with the
--num-trial-runnersargument.Each TrialRunner associated with a single copy of the root Environment, and made unique by means of a unique
trial_runner_idvalue that's included in that Environment's global_config.TODO:
In future PRs we will add: